2021-03-02 19:59:01

by Jiri Slaby

Subject: [PATCH 29/44] tty: xtensa/iss, drop serial_version & serial_name

There is no need to print the information during module load. Neither to
print some artificial version. So drop these strings and a print.

Signed-off-by: Jiri Slaby <[email protected]>
Cc: Chris Zankel <[email protected]>
Cc: Max Filippov <[email protected]>
Cc: [email protected]
---
arch/xtensa/platforms/iss/console.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/arch/xtensa/platforms/iss/console.c b/arch/xtensa/platforms/iss/console.c
index af81a62faba6..1179011044a7 100644
--- a/arch/xtensa/platforms/iss/console.c
+++ b/arch/xtensa/platforms/iss/console.c
@@ -37,9 +37,6 @@ static struct timer_list serial_timer;

static DEFINE_SPINLOCK(timer_lock);

-static char *serial_version = "0.1";
-static char *serial_name = "ISS serial driver";
-
/*
* This routine is called whenever a serial port is opened. It
* enables interrupts for a serial port, linking in its async structure into
@@ -149,7 +146,7 @@ static void rs_wait_until_sent(struct tty_struct *tty, int timeout)

static int rs_proc_show(struct seq_file *m, void *v)
{
- seq_printf(m, "serinfo:1.0 driver:%s\n", serial_version);
+ seq_printf(m, "serinfo:1.0 driver:0.1\n");
return 0;
}

@@ -172,8 +169,6 @@ int __init rs_init(void)

serial_driver = alloc_tty_driver(SERIAL_MAX_NUM_LINES);

- pr_info("%s %s\n", serial_name, serial_version);
-
/* Initialize the tty_driver structure */

serial_driver->driver_name = "iss_serial";
--
2.30.1

2021-03-02 20:06:34

by Max Filippov

Subject: Re: [PATCH 29/44] tty: xtensa/iss, drop serial_version & serial_name

On Mon, Mar 1, 2021 at 10:22 PM Jiri Slaby <[email protected]> wrote:
>
> There is no need to print the information during module load. Neither to
> print some artificial version. So drop these strings and a print.
>
> Signed-off-by: Jiri Slaby <[email protected]>
> Cc: Chris Zankel <[email protected]>
> Cc: Max Filippov <[email protected]>
> Cc: [email protected]
> ---
> arch/xtensa/platforms/iss/console.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)

Acked-by: Max Filippov <[email protected]>

--
Thanks.
-- Max