2022-05-11 10:05:38

by Max Filippov

[permalink] [raw]
Subject: Re: [PATCH -next] xtensa/simdisk: fix error handling in proc_read_simdisk()

Hi Yi,

On Tue, May 10, 2022 at 1:07 AM Yi Yang <[email protected]> wrote:
>
> The frist simple_read_from_buffer() will change ppos. if ppos >= 1.
> The second simple_read_from_buffer() will does not work and return 0.
>
> Fixes: a69755b18774 ("xtensa simdisk: switch to proc_create_data()")
> Signed-off-by: Yi Yang <[email protected]>
> ---
> arch/xtensa/platforms/iss/simdisk.c | 18 +++++++++++++-----
> 1 file changed, 13 insertions(+), 5 deletions(-)

Thank you for the fix. I've rearranged the patch a bit, expanding the commit
message and fixing the build warning that it introduced and have posted v2.
If there's no objections to it I'll add it to my xtensa tree.

--
Thanks.
-- Max