2022-05-18 23:54:25

by Yang Li

Subject: [PATCH -next] xtensa: Return true/false (not 1/0) from bool function

Return boolean values ("true" or "false") instead of 1 or 0 from bool
function. This fixes the following warnings from coccicheck:

./arch/xtensa/kernel/traps.c:304:10-11: WARNING: return of 0/1 in
function 'check_div0' with return type bool

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
arch/xtensa/kernel/traps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/xtensa/kernel/traps.c b/arch/xtensa/kernel/traps.c
index f97d43a8d13d..0c25e035ff10 100644
--- a/arch/xtensa/kernel/traps.c
+++ b/arch/xtensa/kernel/traps.c
@@ -301,7 +301,7 @@ static bool check_div0(struct pt_regs *regs)

if (user_mode(regs)) {
if (copy_from_user(buf, (void __user *)regs->pc + 2, 5))
- return 0;
+ return false;
p = buf;
} else {
p = (const u8 *)regs->pc + 2;
--
2.20.1.7.g153144c

2022-05-23 08:27:42

by Max Filippov

Subject: Re: [PATCH -next] xtensa: Return true/false (not 1/0) from bool function

On Wed, May 18, 2022 at 4:10 PM Yang Li <[email protected]> wrote:
>
> Return boolean values ("true" or "false") instead of 1 or 0 from bool
> function. This fixes the following warnings from coccicheck:
>
> ./arch/xtensa/kernel/traps.c:304:10-11: WARNING: return of 0/1 in
> function 'check_div0' with return type bool
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---
> arch/xtensa/kernel/traps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks! Applied to my xtensa tree.

-- Max