2021-03-10 07:14:34

by Jiapeng Chong

Subject: [PATCH] xtensa: fix warning comparing pointer to 0

Fix the following coccicheck warning:

./arch/xtensa/kernel/pci.c:79:17-18: WARNING comparing pointer to 0.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
arch/xtensa/kernel/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/xtensa/kernel/pci.c b/arch/xtensa/kernel/pci.c
index 3f32e27..62c900e 100644
--- a/arch/xtensa/kernel/pci.c
+++ b/arch/xtensa/kernel/pci.c
@@ -76,7 +76,7 @@ int pci_iobar_pfn(struct pci_dev *pdev, int bar, struct vm_area_struct *vma)
struct pci_controller *pci_ctrl = (struct pci_controller*) pdev->sysdata;
resource_size_t ioaddr = pci_resource_start(pdev, bar);

- if (pci_ctrl == 0)
+ if (!pci_ctrl)
return -EINVAL; /* should never happen */

/* Convert to an offset within this PCI controller */
--
1.8.3.1

2021-03-10 07:37:08

by Max Filippov

Subject: Re: [PATCH] xtensa: fix warning comparing pointer to 0

On Tue, Mar 9, 2021 at 11:10 PM Jiapeng Chong
<[email protected]> wrote:
>
> Fix the following coccicheck warning:
>
> ./arch/xtensa/kernel/pci.c:79:17-18: WARNING comparing pointer to 0.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> arch/xtensa/kernel/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied to my xtensa tree.

--
Thanks.
-- Max