2021-07-30 10:31:23

by Jiapeng Chong

Subject: [PATCH] xtensa: ISS: Fix warning comparing pointer to 0

Fix the following coccicheck warning:

./arch/xtensa/platforms/iss/console.c:204:10-11: WARNING comparing
pointer to 0.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
arch/xtensa/platforms/iss/console.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/xtensa/platforms/iss/console.c b/arch/xtensa/platforms/iss/console.c
index 81f9889..92d4624 100644
--- a/arch/xtensa/platforms/iss/console.c
+++ b/arch/xtensa/platforms/iss/console.c
@@ -201,7 +201,7 @@ static void iss_console_write(struct console *co, const char *s, unsigned count)
{
int len = strlen(s);

- if (s != 0 && *s != 0)
+ if (s && *s != 0)
simc_write(1, s, count < len ? count : len);
}

--
1.8.3.1

2021-08-10 23:23:22

by Max Filippov

Subject: Re: [PATCH] xtensa: ISS: Fix warning comparing pointer to 0

Hi Jiapeng,

On Fri, Jul 30, 2021 at 3:30 AM Jiapeng Chong
<[email protected]> wrote:
>
> Fix the following coccicheck warning:
>
> ./arch/xtensa/platforms/iss/console.c:204:10-11: WARNING comparing
> pointer to 0.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> arch/xtensa/platforms/iss/console.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/xtensa/platforms/iss/console.c b/arch/xtensa/platforms/iss/console.c
> index 81f9889..92d4624 100644
> --- a/arch/xtensa/platforms/iss/console.c
> +++ b/arch/xtensa/platforms/iss/console.c
> @@ -201,7 +201,7 @@ static void iss_console_write(struct console *co, const char *s, unsigned count)
> {
> int len = strlen(s);

Here's a bigger issue in this function: s is used in strlen before it
is checked for NULL.
I've posted another patch that fixes it.

> - if (s != 0 && *s != 0)
> + if (s && *s != 0)
> simc_write(1, s, count < len ? count : len);
> }
>
> --
> 1.8.3.1
>

--
Thanks.
-- Max