2020-12-15 13:25:26

by Mark Brown

Subject: [PATCH] regulator: pf8x00: Use specific compatible strings for devices

The pf8x00 driver supports three devices, the DT compatible strings
and I2C IDs should enumerate these specifically rather than using a
wildcard so that we don't collide with anything incompatible in the
same ID range in the future and so that we can handle any software
visible differences between the variants we find.

Signed-off-by: Mark Brown <[email protected]>
---
.../bindings/regulator/nxp,pf8x00-regulator.yaml | 6 ++++--
drivers/regulator/pf8x00-regulator.c | 8 ++++++--
2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml
index a6c259ce9785..956156fe52a3 100644
--- a/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml
@@ -19,7 +19,9 @@ description: |
properties:
compatible:
enum:
- - nxp,pf8x00
+ - nxp,pf8100
+ - nxp,pf8121a
+ - nxp,pf8200

reg:
maxItems: 1
@@ -118,7 +120,7 @@ examples:
#size-cells = <0>;

pmic@8 {
- compatible = "nxp,pf8x00";
+ compatible = "nxp,pf8100";
reg = <0x08>;

regulators {
diff --git a/drivers/regulator/pf8x00-regulator.c b/drivers/regulator/pf8x00-regulator.c
index 308c27fa6ea8..af9918cd27aa 100644
--- a/drivers/regulator/pf8x00-regulator.c
+++ b/drivers/regulator/pf8x00-regulator.c
@@ -469,13 +469,17 @@ static int pf8x00_i2c_probe(struct i2c_client *client)
}

static const struct of_device_id pf8x00_dt_ids[] = {
- { .compatible = "nxp,pf8x00",},
+ { .compatible = "nxp,pf8100",},
+ { .compatible = "nxp,pf8121a",},
+ { .compatible = "nxp,pf8200",},
{ }
};
MODULE_DEVICE_TABLE(of, pf8x00_dt_ids);

static const struct i2c_device_id pf8x00_i2c_id[] = {
- { "pf8x00", 0 },
+ { "pf8100", 0 },
+ { "pf8121a", 0 },
+ { "pf8200", 0 },
{},
};
MODULE_DEVICE_TABLE(i2c, pf8x00_i2c_id);
--
2.20.1

2020-12-15 20:24:15

by Jagan Teki

Subject: Re: [PATCH] regulator: pf8x00: Use specific compatible strings for devices

On Tue, Dec 15, 2020 at 6:50 PM Mark Brown <[email protected]> wrote:
>
> The pf8x00 driver supports three devices, the DT compatible strings
> and I2C IDs should enumerate these specifically rather than using a
> wildcard so that we don't collide with anything incompatible in the
> same ID range in the future and so that we can handle any software
> visible differences between the variants we find.

Thanks for the patch.

>
> Signed-off-by: Mark Brown <[email protected]>
> ---
> .../bindings/regulator/nxp,pf8x00-regulator.yaml | 6 ++++--
> drivers/regulator/pf8x00-regulator.c | 8 ++++++--

I think the bindings patch would be separate? otherwise,

Reviewed-by: Jagan Teki <[email protected]>