2017-08-27 07:33:20

by Himanshu Jha

Subject: [PATCH] nubus: remove cast to void pointer

Casting void pointers to other pointer types in unnecessary.

Signed-off-by: Himanshu Jha <[email protected]>
---
drivers/nubus/nubus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/nubus/nubus.c b/drivers/nubus/nubus.c
index df431e8..5450f1a 100644
--- a/drivers/nubus/nubus.c
+++ b/drivers/nubus/nubus.c
@@ -167,7 +167,7 @@ static unsigned char *nubus_dirptr(const struct nubus_dirent *nd)
void nubus_get_rsrc_mem(void *dest, const struct nubus_dirent *dirent,
int len)
{
- unsigned char *t = (unsigned char *)dest;
+ unsigned char *t = dest;
unsigned char *p = nubus_dirptr(dirent);

while (len) {
@@ -180,7 +180,7 @@ EXPORT_SYMBOL(nubus_get_rsrc_mem);
void nubus_get_rsrc_str(void *dest, const struct nubus_dirent *dirent,
int len)
{
- unsigned char *t = (unsigned char *)dest;
+ unsigned char *t = dest;
unsigned char *p = nubus_dirptr(dirent);

while (len) {
--
2.7.4

2019-09-27 12:48:36

by Geert Uytterhoeven

Subject: Re: [PATCH] nubus: remove cast to void pointer

Hi Himanshu,

On Sun, Aug 27, 2017 at 9:33 AM Himanshu Jha
<[email protected]> wrote:
> Casting void pointers to other pointer types in unnecessary.
>
> Signed-off-by: Himanshu Jha <[email protected]>

Thanks for your patch!

> --- a/drivers/nubus/nubus.c
> +++ b/drivers/nubus/nubus.c
> @@ -167,7 +167,7 @@ static unsigned char *nubus_dirptr(const struct nubus_dirent *nd)
> void nubus_get_rsrc_mem(void *dest, const struct nubus_dirent *dirent,
> int len)
> {
> - unsigned char *t = (unsigned char *)dest;
> + unsigned char *t = dest;
> unsigned char *p = nubus_dirptr(dirent);
>
> while (len) {
> @@ -180,7 +180,7 @@ EXPORT_SYMBOL(nubus_get_rsrc_mem);
> void nubus_get_rsrc_str(void *dest, const struct nubus_dirent *dirent,
> int len)
> {
> - unsigned char *t = (unsigned char *)dest;
> + unsigned char *t = dest;
> unsigned char *p = nubus_dirptr(dirent);
>
> while (len) {

The second chunk is no longer valid, but the first one still is.

Reviewed-by: Geert Uytterhoeven <[email protected]>
i.e. will queue the first chunk for v5.5.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds