2019-07-30 23:44:35

by Stephen Boyd

Subject: [PATCH v2 2/2] idr: Document that ida_simple_{get,remove}() are deprecated

These two functions are deprecated. Users should call ida_alloc() or
ida_free() respectively instead. Add documentation to this effect until
the macro can be removed.

Cc: Greg KH <[email protected]>
Cc: Tri Vo <[email protected]>
Cc: Jonathan Corbet <[email protected]>
Cc: [email protected]
Signed-off-by: Stephen Boyd <[email protected]>
---
include/linux/idr.h | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/include/linux/idr.h b/include/linux/idr.h
index 5bb026007044..12f7233c7adb 100644
--- a/include/linux/idr.h
+++ b/include/linux/idr.h
@@ -314,6 +314,10 @@ static inline void ida_init(struct ida *ida)
xa_init_flags(&ida->xa, IDA_INIT_FLAGS);
}

+/*
+ * ida_simple_get() and ida_simple_remove() are deprecated. Use
+ * ida_alloc() and ida_free() instead respectively.
+ */
#define ida_simple_get(ida, start, end, gfp) \
ida_alloc_range(ida, start, (end) - 1, gfp)
#define ida_simple_remove(ida, id) ida_free(ida, id)
--
Sent by a computer through tubes

2019-08-02 02:22:39

by Tri Vo

Subject: Re: [PATCH v2 2/2] idr: Document that ida_simple_{get,remove}() are deprecated

On Tue, Jul 30, 2019 at 2:20 PM Stephen Boyd <[email protected]> wrote:
>
> These two functions are deprecated. Users should call ida_alloc() or
> ida_free() respectively instead. Add documentation to this effect until
> the macro can be removed.
>
> Cc: Greg KH <[email protected]>
> Cc: Tri Vo <[email protected]>
> Cc: Jonathan Corbet <[email protected]>
> Cc: [email protected]
> Signed-off-by: Stephen Boyd <[email protected]>

Reviewed-by: Tri Vo <[email protected]>