2012-06-06 13:24:07

by Hillf Danton

Subject: [patch] BFS 421: confine for_each_domain to SMP

Lets trap the insane build.


--- a/kernel/sched/bfs.c Wed Jun 6 20:56:22 2012
+++ b/kernel/sched/bfs.c Wed Jun 6 21:01:00 2012
@@ -324,7 +324,6 @@ int __weak arch_sd_sibling_asym_packing(
{
return 0*SD_ASYM_PACKING;
}
-#endif

#define rcu_dereference_check_sched_domain(p) \
rcu_dereference_check((p), \
@@ -339,6 +338,9 @@ int __weak arch_sd_sibling_asym_packing(
*/
#define for_each_domain(cpu, __sd) \
for (__sd = rcu_dereference_check_sched_domain(cpu_rq(cpu)->sd);
__sd; __sd = __sd->parent)
+#else
+#define for_each_domain(cpu, __sd) BUILD_BUG()
+#endif

static inline void update_rq_clock(struct rq *rq);

--

2012-06-06 14:46:40

by Chen

Subject: Re: [patch] BFS 421: confine for_each_domain to SMP

On Wed, Jun 6, 2012 at 10:46 PM, Chen <[email protected]> wrote:
> On Wed, Jun 6, 2012 at 9:23 PM, Hillf Danton <[email protected]> wrote:
>> Lets trap the insane build.
>>
>>
>> --- a/kernel/sched/bfs.c ? ? ? ?Wed Jun ?6 20:56:22 2012
>> +++ b/kernel/sched/bfs.c ? ? ? ?Wed Jun ?6 21:01:00 2012
>> @@ -324,7 +324,6 @@ int __weak arch_sd_sibling_asym_packing(
>> ?{
>> ? ? ? ?return 0*SD_ASYM_PACKING;
>> ?}
>> -#endif
>>
>> ?#define rcu_dereference_check_sched_domain(p) \
>> ? ? ? ?rcu_dereference_check((p), \
>> @@ -339,6 +338,9 @@ int __weak arch_sd_sibling_asym_packing(
>> ?*/
>> ?#define for_each_domain(cpu, __sd) \
>> ? ? ? ?for (__sd = rcu_dereference_check_sched_domain(cpu_rq(cpu)->sd);
>> __sd; __sd = __sd->parent)
>> +#else
>> +#define for_each_domain(cpu, __sd) ? ? BUILD_BUG()
>> +#endif
>>
>> ?static inline void update_rq_clock(struct rq *rq);
>>
>> --
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to [email protected]
>> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at ?http://www.tux.org/lkml/
>
> Good! You haven't give up, Hilff. :-)