2023-01-16 15:25:28

by Tanmay Bhushan

[permalink] [raw]
Subject: [PATCH] ipv6: Remove extra counter pull before gc

Per cpu entries are no longer used in consideration
for doing gc or not. Remove the extra per cpu entries
pull to directly check for time and perform gc.

Signed-off-by: Tanmay Bhushan <[email protected]>
---
net/ipv6/route.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index b643dda68d31..76889ceeead9 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -3294,10 +3294,6 @@ static void ip6_dst_gc(struct dst_ops *ops)
unsigned int val;
int entries;

- entries = dst_entries_get_fast(ops);
- if (entries > ops->gc_thresh)
- entries = dst_entries_get_slow(ops);
-
if (time_after(rt_last_gc + rt_min_interval, jiffies))
goto out;

--
2.34.1


2023-01-16 16:58:33

by Eric Dumazet

[permalink] [raw]
Subject: Re: [PATCH] ipv6: Remove extra counter pull before gc

On Mon, Jan 16, 2023 at 3:55 PM Tanmay Bhushan <[email protected]> wrote:
>
> Per cpu entries are no longer used in consideration
> for doing gc or not. Remove the extra per cpu entries
> pull to directly check for time and perform gc.
>
> Signed-off-by: Tanmay Bhushan <[email protected]>
> ---
> net/ipv6/route.c | 4 ----
> 1 file changed, 4 deletions(-)
>

OK, please next time specify which tree your patch is targeting (this
is for net-next tree here)

Reviewed-by: Eric Dumazet <[email protected]>

Thanks.

2023-01-18 14:33:00

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH] ipv6: Remove extra counter pull before gc

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <[email protected]>:

On Mon, 16 Jan 2023 15:55:00 +0100 you wrote:
> Per cpu entries are no longer used in consideration
> for doing gc or not. Remove the extra per cpu entries
> pull to directly check for time and perform gc.
>
> Signed-off-by: Tanmay Bhushan <[email protected]>
> ---
> net/ipv6/route.c | 4 ----
> 1 file changed, 4 deletions(-)

Here is the summary with links:
- ipv6: Remove extra counter pull before gc
https://git.kernel.org/netdev/net-next/c/9259f6b573cf

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html