2024-06-11 07:59:20

by Dmitry Vyukov

Subject: [PATCH v2 3/4] module: Fix KCOV-ignored file name

Module.c was renamed to main.c, but the Makefile directive
was copy-pasted verbatim with the old file name.
Fix up the file name.

Signed-off-by: Dmitry Vyukov <[email protected]>
Reviewed-by: Alexander Potapenko <[email protected]>
Fixes: cfc1d277891e ("module: Move all into module/")
Cc: Aaron Tomlin <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
kernel/module/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/module/Makefile b/kernel/module/Makefile
index a10b2b9a6fdf..50ffcc413b54 100644
--- a/kernel/module/Makefile
+++ b/kernel/module/Makefile
@@ -5,7 +5,7 @@

# These are called from save_stack_trace() on slub debug path,
# and produce insane amounts of uninteresting coverage.
-KCOV_INSTRUMENT_module.o := n
+KCOV_INSTRUMENT_main.o := n

obj-y += main.o
obj-y += strict_rwx.o
--
2.45.2.505.gda0bf45e8d-goog

2024-06-11 09:58:15

by Marco Elver

Subject: Re: [PATCH v2 3/4] module: Fix KCOV-ignored file name

On Tue, 11 Jun 2024 at 09:50, Dmitry Vyukov <[email protected]> wrote:
>
> Module.c was renamed to main.c, but the Makefile directive
> was copy-pasted verbatim with the old file name.
> Fix up the file name.
>
> Signed-off-by: Dmitry Vyukov <[email protected]>
> Reviewed-by: Alexander Potapenko <[email protected]>
> Fixes: cfc1d277891e ("module: Move all into module/")
> Cc: Aaron Tomlin <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]

Reviewed-by: Marco Elver <[email protected]>

> ---
> kernel/module/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/module/Makefile b/kernel/module/Makefile
> index a10b2b9a6fdf..50ffcc413b54 100644
> --- a/kernel/module/Makefile
> +++ b/kernel/module/Makefile
> @@ -5,7 +5,7 @@
>
> # These are called from save_stack_trace() on slub debug path,
> # and produce insane amounts of uninteresting coverage.
> -KCOV_INSTRUMENT_module.o := n
> +KCOV_INSTRUMENT_main.o := n
>
> obj-y += main.o
> obj-y += strict_rwx.o
> --
> 2.45.2.505.gda0bf45e8d-goog
>

2024-06-13 22:56:04

by Andrey Konovalov

Subject: Re: [PATCH v2 3/4] module: Fix KCOV-ignored file name

On Tue, Jun 11, 2024 at 9:50 AM 'Dmitry Vyukov' via syzkaller
<[email protected]> wrote:
>
> Module.c was renamed to main.c, but the Makefile directive
> was copy-pasted verbatim with the old file name.
> Fix up the file name.
>
> Signed-off-by: Dmitry Vyukov <[email protected]>
> Reviewed-by: Alexander Potapenko <[email protected]>
> Fixes: cfc1d277891e ("module: Move all into module/")
> Cc: Aaron Tomlin <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> ---
> kernel/module/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/module/Makefile b/kernel/module/Makefile
> index a10b2b9a6fdf..50ffcc413b54 100644
> --- a/kernel/module/Makefile
> +++ b/kernel/module/Makefile
> @@ -5,7 +5,7 @@
>
> # These are called from save_stack_trace() on slub debug path,
> # and produce insane amounts of uninteresting coverage.
> -KCOV_INSTRUMENT_module.o := n
> +KCOV_INSTRUMENT_main.o := n
>
> obj-y += main.o
> obj-y += strict_rwx.o
> --
> 2.45.2.505.gda0bf45e8d-goog

Reviewed-by: Andrey Konovalov <[email protected]>