Hi all,
After merging the arm-soc tree, today's linux-next build (x86_64
allmodconfig) failed like this:
sound/arm/pxa2xx-pcm-lib.c: In function '__pxa2xx_pcm_open':
sound/arm/pxa2xx-pcm-lib.c:129:6: error: 'pxad_filter_fn' undeclared (first use in this function); did you mean 'dma_filter_fn'?
pxad_filter_fn,
^~~~~~~~~~~~~~
dma_filter_fn
Caused by commit
0d0b16b8e008 ("dmaengine: pxa: make the filter function internal")
I have used the arm-soc tree from next-20180713 for today.
--
Cheers,
Stephen Rothwell
On Sun, Jul 15, 2018 at 4:13 PM, Stephen Rothwell <[email protected]> wrote:
> Hi all,
>
> After merging the arm-soc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> sound/arm/pxa2xx-pcm-lib.c: In function '__pxa2xx_pcm_open':
> sound/arm/pxa2xx-pcm-lib.c:129:6: error: 'pxad_filter_fn' undeclared (first use in this function); did you mean 'dma_filter_fn'?
> pxad_filter_fn,
> ^~~~~~~~~~~~~~
> dma_filter_fn
>
> Caused by commit
>
> 0d0b16b8e008 ("dmaengine: pxa: make the filter function internal")
>
> I have used the arm-soc tree from next-20180713 for today.
It's a known issue due to dependencies with a driver tree. :(
Robert, this is unfortunate. What's the dependent patches? We can pick
them up in our tree as duplicates if needed.
-Olof
On Sun, Jul 15, 2018 at 4:50 PM, Olof Johansson <[email protected]> wrote:
> On Sun, Jul 15, 2018 at 4:13 PM, Stephen Rothwell <[email protected]> wrote:
>> Hi all,
>>
>> After merging the arm-soc tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> sound/arm/pxa2xx-pcm-lib.c: In function '__pxa2xx_pcm_open':
>> sound/arm/pxa2xx-pcm-lib.c:129:6: error: 'pxad_filter_fn' undeclared (first use in this function); did you mean 'dma_filter_fn'?
>> pxad_filter_fn,
>> ^~~~~~~~~~~~~~
>> dma_filter_fn
>>
>> Caused by commit
>>
>> 0d0b16b8e008 ("dmaengine: pxa: make the filter function internal")
>>
>> I have used the arm-soc tree from next-20180713 for today.
>
> It's a known issue due to dependencies with a driver tree. :(
>
> Robert, this is unfortunate. What's the dependent patches? We can pick
> them up in our tree as duplicates if needed.
Ok, it was easy to drop PXA this time around, so I've done that.
Stephen; arm-soc/for-next should be building again (for tomorrow).
Thanks,
-Olof
Olof Johansson <[email protected]> writes:
> It's a known issue due to dependencies with a driver tree. :(
>
> Robert, this is unfortunate. What's the dependent patches? We can pick
> them up in our tree as duplicates if needed.
I'd rather postpone one of the patches, as I explained in the pull request.
As Stephen noticed, this will be :
0d0b16b8e008 ("dmaengine: pxa: make the filter function internal")
I'll queue this one for the 4.20 cycle. By the way, all of this cames from the
fact that I didn't take this very patch in my imutable branch for this change
...
I'll also resend a pull request, without this patch if that's good for you,
which will solve the breakage.
Cheers.
--
Robert