2023-01-21 08:20:02

by Asahi Lina

Subject: [PATCH] soc: apple: rtkit: Add a private pointer to apple_rtkit_shmem

This allows downstream consumers to keep track of private data for shmem
mappings. In particular, the Rust abstraction will use this to safely
drop data associated with a mapping when it is unmapped.

Signed-off-by: Asahi Lina <[email protected]>
---
include/linux/soc/apple/rtkit.h | 2 ++
1 file changed, 2 insertions(+)

diff --git a/include/linux/soc/apple/rtkit.h b/include/linux/soc/apple/rtkit.h
index 62bfa37b5adb..1a9888a1797a 100644
--- a/include/linux/soc/apple/rtkit.h
+++ b/include/linux/soc/apple/rtkit.h
@@ -22,6 +22,7 @@
* @size: Size of the shared memory buffer.
* @iova: Device VA of shared memory buffer.
* @is_mapped: Shared memory buffer is managed by the co-processor.
+ * @private: Private data pointer for the parent driver.
*/

struct apple_rtkit_shmem {
@@ -30,6 +31,7 @@ struct apple_rtkit_shmem {
size_t size;
dma_addr_t iova;
bool is_mapped;
+ void *private;
};

/*
--
2.35.1

2023-01-22 10:26:02

by Sven Peter

Subject: Re: [PATCH] soc: apple: rtkit: Add a private pointer to apple_rtkit_shmem

On Sat, Jan 21, 2023, at 08:42, Asahi Lina wrote:
> This allows downstream consumers to keep track of private data for shmem
> mappings. In particular, the Rust abstraction will use this to safely
> drop data associated with a mapping when it is unmapped.
>
> Signed-off-by: Asahi Lina <[email protected]>
> ---

Reviewed-by: Sven Peter <[email protected]>

thanks,

Sven

2023-01-22 12:36:39

by Eric Curtin

Subject: Re: [PATCH] soc: apple: rtkit: Add a private pointer to apple_rtkit_shmem

On Sat, 21 Jan 2023 at 07:53, Asahi Lina <[email protected]> wrote:
>
> This allows downstream consumers to keep track of private data for shmem
> mappings. In particular, the Rust abstraction will use this to safely
> drop data associated with a mapping when it is unmapped.
>
> Signed-off-by: Asahi Lina <[email protected]>
> ---

Signed-off-by: Eric Curtin <[email protected]>

> include/linux/soc/apple/rtkit.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/soc/apple/rtkit.h b/include/linux/soc/apple/rtkit.h
> index 62bfa37b5adb..1a9888a1797a 100644
> --- a/include/linux/soc/apple/rtkit.h
> +++ b/include/linux/soc/apple/rtkit.h
> @@ -22,6 +22,7 @@
> * @size: Size of the shared memory buffer.
> * @iova: Device VA of shared memory buffer.
> * @is_mapped: Shared memory buffer is managed by the co-processor.
> + * @private: Private data pointer for the parent driver.
> */
>
> struct apple_rtkit_shmem {
> @@ -30,6 +31,7 @@ struct apple_rtkit_shmem {
> size_t size;
> dma_addr_t iova;
> bool is_mapped;
> + void *private;
> };
>
> /*
> --
> 2.35.1
>
>

2023-01-22 18:06:22

by Eric Curtin

Subject: Re: [PATCH] soc: apple: rtkit: Add a private pointer to apple_rtkit_shmem

Is mise le meas/Regards,

Eric Curtin


On Sat, 21 Jan 2023 at 07:53, Asahi Lina <[email protected]> wrote:
>
> This allows downstream consumers to keep track of private data for shmem
> mappings. In particular, the Rust abstraction will use this to safely
> drop data associated with a mapping when it is unmapped.
>
> Signed-off-by: Asahi Lina <[email protected]>
> ---

Sorry Lina, these were obviously supposed to not be signed off tags, but:

Reviewed-by: Eric Curtin <[email protected]>

that's what you get, when you copy a tag from somewhere else!

> include/linux/soc/apple/rtkit.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/soc/apple/rtkit.h b/include/linux/soc/apple/rtkit.h
> index 62bfa37b5adb..1a9888a1797a 100644
> --- a/include/linux/soc/apple/rtkit.h
> +++ b/include/linux/soc/apple/rtkit.h
> @@ -22,6 +22,7 @@
> * @size: Size of the shared memory buffer.
> * @iova: Device VA of shared memory buffer.
> * @is_mapped: Shared memory buffer is managed by the co-processor.
> + * @private: Private data pointer for the parent driver.
> */
>
> struct apple_rtkit_shmem {
> @@ -30,6 +31,7 @@ struct apple_rtkit_shmem {
> size_t size;
> dma_addr_t iova;
> bool is_mapped;
> + void *private;
> };
>
> /*
> --
> 2.35.1
>
>

2023-01-31 11:42:12

by Hector Martin

Subject: Re: [PATCH] soc: apple: rtkit: Add a private pointer to apple_rtkit_shmem

On 21/01/2023 16.42, Asahi Lina wrote:
> This allows downstream consumers to keep track of private data for shmem
> mappings. In particular, the Rust abstraction will use this to safely
> drop data associated with a mapping when it is unmapped.
>
> Signed-off-by: Asahi Lina <[email protected]>
> ---
> include/linux/soc/apple/rtkit.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/soc/apple/rtkit.h b/include/linux/soc/apple/rtkit.h
> index 62bfa37b5adb..1a9888a1797a 100644
> --- a/include/linux/soc/apple/rtkit.h
> +++ b/include/linux/soc/apple/rtkit.h
> @@ -22,6 +22,7 @@
> * @size: Size of the shared memory buffer.
> * @iova: Device VA of shared memory buffer.
> * @is_mapped: Shared memory buffer is managed by the co-processor.
> + * @private: Private data pointer for the parent driver.
> */
>
> struct apple_rtkit_shmem {
> @@ -30,6 +31,7 @@ struct apple_rtkit_shmem {
> size_t size;
> dma_addr_t iova;
> bool is_mapped;
> + void *private;
> };
>
> /*

Thanks, applied to asahi-soc/soc!

- Hector