2022-01-13 05:16:40

by Aniruddha Rao

Subject: [PATCH] mmc: tegra: Enable wake on SD card event

Enable GPIO wake source on SD card detect line.
Physical card insertion/removal event should wake the system
from suspend.

Signed-off-by: Aniruddha Rao <[email protected]>
---
drivers/mmc/host/sdhci-tegra.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
index 35ebba0..5c84bd5 100644
--- a/drivers/mmc/host/sdhci-tegra.c
+++ b/drivers/mmc/host/sdhci-tegra.c
@@ -1673,6 +1673,9 @@ static int sdhci_tegra_probe(struct platform_device *pdev)
/* HW busy detection is supported, but R1B responses are required. */
host->mmc->caps |= MMC_CAP_WAIT_WHILE_BUSY | MMC_CAP_NEED_RSP_BUSY;

+ /* GPIO CD can be set as a wakeup source */
+ host->mmc->caps |= MMC_CAP_CD_WAKE;
+
tegra_sdhci_parse_dt(host);

tegra_host->power_gpio = devm_gpiod_get_optional(&pdev->dev, "power",
@@ -1840,7 +1843,7 @@ static int sdhci_tegra_suspend(struct device *dev)
return ret;
}

- return 0;
+ return mmc_gpio_set_cd_wake(host->mmc, true);
}

static int sdhci_tegra_resume(struct device *dev)
@@ -1848,6 +1851,10 @@ static int sdhci_tegra_resume(struct device *dev)
struct sdhci_host *host = dev_get_drvdata(dev);
int ret;

+ ret = mmc_gpio_set_cd_wake(host->mmc, false);
+ if (ret)
+ return ret;
+
ret = pm_runtime_force_resume(dev);
if (ret)
return ret;
--
2.7.4

2022-01-13 06:44:18

by Adrian Hunter

Subject: Re: [PATCH] mmc: tegra: Enable wake on SD card event

On 13/01/2022 07:16, Aniruddha Rao wrote:
> Enable GPIO wake source on SD card detect line.
> Physical card insertion/removal event should wake the system
> from suspend.
>
> Signed-off-by: Aniruddha Rao <[email protected]>

Acked-by: Adrian Hunter <[email protected]>

> ---
> drivers/mmc/host/sdhci-tegra.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index 35ebba0..5c84bd5 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -1673,6 +1673,9 @@ static int sdhci_tegra_probe(struct platform_device *pdev)
> /* HW busy detection is supported, but R1B responses are required. */
> host->mmc->caps |= MMC_CAP_WAIT_WHILE_BUSY | MMC_CAP_NEED_RSP_BUSY;
>
> + /* GPIO CD can be set as a wakeup source */
> + host->mmc->caps |= MMC_CAP_CD_WAKE;
> +
> tegra_sdhci_parse_dt(host);
>
> tegra_host->power_gpio = devm_gpiod_get_optional(&pdev->dev, "power",
> @@ -1840,7 +1843,7 @@ static int sdhci_tegra_suspend(struct device *dev)
> return ret;
> }
>
> - return 0;
> + return mmc_gpio_set_cd_wake(host->mmc, true);
> }
>
> static int sdhci_tegra_resume(struct device *dev)
> @@ -1848,6 +1851,10 @@ static int sdhci_tegra_resume(struct device *dev)
> struct sdhci_host *host = dev_get_drvdata(dev);
> int ret;
>
> + ret = mmc_gpio_set_cd_wake(host->mmc, false);
> + if (ret)
> + return ret;
> +
> ret = pm_runtime_force_resume(dev);
> if (ret)
> return ret;
>

2022-01-24 19:23:24

by Ulf Hansson

Subject: Re: [PATCH] mmc: tegra: Enable wake on SD card event

On Thu, 13 Jan 2022 at 06:16, Aniruddha Rao <[email protected]> wrote:
>
> Enable GPIO wake source on SD card detect line.
> Physical card insertion/removal event should wake the system
> from suspend.
>
> Signed-off-by: Aniruddha Rao <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


> ---
> drivers/mmc/host/sdhci-tegra.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index 35ebba0..5c84bd5 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -1673,6 +1673,9 @@ static int sdhci_tegra_probe(struct platform_device *pdev)
> /* HW busy detection is supported, but R1B responses are required. */
> host->mmc->caps |= MMC_CAP_WAIT_WHILE_BUSY | MMC_CAP_NEED_RSP_BUSY;
>
> + /* GPIO CD can be set as a wakeup source */
> + host->mmc->caps |= MMC_CAP_CD_WAKE;
> +
> tegra_sdhci_parse_dt(host);
>
> tegra_host->power_gpio = devm_gpiod_get_optional(&pdev->dev, "power",
> @@ -1840,7 +1843,7 @@ static int sdhci_tegra_suspend(struct device *dev)
> return ret;
> }
>
> - return 0;
> + return mmc_gpio_set_cd_wake(host->mmc, true);
> }
>
> static int sdhci_tegra_resume(struct device *dev)
> @@ -1848,6 +1851,10 @@ static int sdhci_tegra_resume(struct device *dev)
> struct sdhci_host *host = dev_get_drvdata(dev);
> int ret;
>
> + ret = mmc_gpio_set_cd_wake(host->mmc, false);
> + if (ret)
> + return ret;
> +
> ret = pm_runtime_force_resume(dev);
> if (ret)
> return ret;
> --
> 2.7.4
>