2013-05-13 06:26:04

by Wei Yongjun

[permalink] [raw]
Subject: [PATCH] rtc: rtc-vr41xx: fix error return code in rtc_probe()

From: Wei Yongjun <[email protected]>

Fix to return -EBUSY in the platform irq get error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/rtc/rtc-vr41xx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-vr41xx.c b/drivers/rtc/rtc-vr41xx.c
index 3b5b4fa..54e104e 100644
--- a/drivers/rtc/rtc-vr41xx.c
+++ b/drivers/rtc/rtc-vr41xx.c
@@ -339,8 +339,10 @@ static int rtc_probe(struct platform_device *pdev)
goto err_device_unregister;

pie_irq = platform_get_irq(pdev, 1);
- if (pie_irq <= 0)
+ if (pie_irq <= 0) {
+ retval = -EBUSY;
goto err_free_irq;
+ }

retval = request_irq(pie_irq, rtclong1_interrupt, 0,
"rtclong1", pdev);