2013-05-07 11:38:55

by Wei Yongjun

[permalink] [raw]
Subject: [PATCH] ASoC: wm0010: fix error return code in wm0010_boot()

From: Wei Yongjun <[email protected]>

Fix to return -ENOMEM in the memory malloc of 'out' and 'img_swap' error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <[email protected]>
---
sound/soc/codecs/wm0010.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c
index 8df2b6e..370af0c 100644
--- a/sound/soc/codecs/wm0010.c
+++ b/sound/soc/codecs/wm0010.c
@@ -667,6 +667,7 @@ static int wm0010_boot(struct snd_soc_codec *codec)
/* On wm0010 only the CLKCTRL1 value is used */
pll_rec.clkctrl1 = wm0010->pll_clkctrl1;

+ ret = -ENOMEM;
len = pll_rec.length + 8;
out = kzalloc(len, GFP_KERNEL);
if (!out) {


2013-05-07 13:55:07

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] ASoC: wm0010: fix error return code in wm0010_boot()

On Tue, May 07, 2013 at 07:38:52PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> Fix to return -ENOMEM in the memory malloc of 'out' and 'img_swap' error
> handling case instead of 0, as done elsewhere in this function.

Applied, thanks. Please note my new e-mail address.


Attachments:
(No filename) (311.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments