2013-03-11 13:45:37

by Wei Yongjun

[permalink] [raw]
Subject: [PATCH -next] staging: sync: fix return value check in sync_fence_alloc()

From: Wei Yongjun <[email protected]>

In case of error, the function anon_inode_getfile() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/staging/android/sync.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
index b9bb974..bf66c19 100644
--- a/drivers/staging/android/sync.c
+++ b/drivers/staging/android/sync.c
@@ -261,7 +261,7 @@ static struct sync_fence *sync_fence_alloc(const char *name)

fence->file = anon_inode_getfile("sync_fence", &sync_fence_fops,
fence, 0);
- if (fence->file == NULL)
+ if (IS_ERR(fence->file))
goto err;

kref_init(&fence->kref);