2013-05-28 09:07:56

by Wei Yongjun

Subject: [PATCH -next] dmaengine: ste_dma40: add missing iounmap() on error in d40_probe()

From: Wei Yongjun <[email protected]>

Add the missing iounmap() before return from d40_probe()
in the error handling case.

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/dma/ste_dma40.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index 71bf4ec..018c2f7 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -3612,6 +3612,8 @@ failure:
kmem_cache_destroy(base->desc_slab);
if (base->virtbase)
iounmap(base->virtbase);
+ if (base->lcpa_base)
+ iounmap(base->lcpa_base);

if (base->lcla_pool.base && base->plat_data->use_esram_lcla) {
iounmap(base->lcla_pool.base);

2013-05-29 15:46:19

by Linus Walleij

Subject: Re: [PATCH -next] dmaengine: ste_dma40: add missing iounmap() on error in d40_probe()

Hi Wei,

why does the patch subject say -next?

AFAICS the patch applies to Torvalds tree as well, and should probably
go in for fixes.

On Tue, May 28, 2013 at 11:07 AM, Wei Yongjun <[email protected]> wrote:

> From: Wei Yongjun <[email protected]>
>
> Add the missing iounmap() before return from d40_probe()
> in the error handling case.
>
> Signed-off-by: Wei Yongjun <[email protected]>

Acked-by: Linus Walleij <[email protected]>

I guess Vinod should apply this... maybe it should even be marked
for stable.

Yours,
Linus Walleij