2013-04-23 02:47:48

by Wei Yongjun

Subject: [PATCH -next] iommu/amd: fix error return code in early_amd_iommu_init()

From: Wei Yongjun <[email protected]>

Fix to return -ENOMEM int the memory alloc error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/iommu/amd_iommu_init.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
index 9110c1c..a55ec50 100644
--- a/drivers/iommu/amd_iommu_init.c
+++ b/drivers/iommu/amd_iommu_init.c
@@ -1860,6 +1860,7 @@ static int __init early_amd_iommu_init(void)
* Interrupt remapping enabled, create kmem_cache for the
* remapping tables.
*/
+ ret = -ENOMEM;
amd_iommu_irq_cache = kmem_cache_create("irq_remap_cache",
MAX_IRQS_PER_TABLE * sizeof(u32),
IRQ_TABLE_ALIGNMENT,

2013-04-23 12:38:43

by Joerg Roedel

Subject: Re: [PATCH -next] iommu/amd: fix error return code in early_amd_iommu_init()

On Tue, Apr 23, 2013 at 10:47:44AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> Fix to return -ENOMEM int the memory alloc error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
> drivers/iommu/amd_iommu_init.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
> index 9110c1c..a55ec50 100644
> --- a/drivers/iommu/amd_iommu_init.c
> +++ b/drivers/iommu/amd_iommu_init.c
> @@ -1860,6 +1860,7 @@ static int __init early_amd_iommu_init(void)
> * Interrupt remapping enabled, create kmem_cache for the
> * remapping tables.
> */
> + ret = -ENOMEM;
> amd_iommu_irq_cache = kmem_cache_create("irq_remap_cache",
> MAX_IRQS_PER_TABLE * sizeof(u32),
> IRQ_TABLE_ALIGNMENT,
>

Applied to x86/amd, thanks.