2020-09-08 15:55:48

by Christoph Hellwig

Subject: [PATCH 15/19] md: use bdev_check_media_change

The md driver does not have a ->revalidate_disk method, so it can just
use bdev_check_media_change without any additional changes.

Signed-off-by: Christoph Hellwig <[email protected]>
Reviewed-by: Johannes Thumshirn <[email protected]>
---
drivers/md/md.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 9562ef598ae1f4..27ed61197014ef 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -7848,7 +7848,7 @@ static int md_open(struct block_device *bdev, fmode_t mode)
atomic_inc(&mddev->openers);
mutex_unlock(&mddev->open_mutex);

- check_disk_change(bdev);
+ bdev_check_media_change(bdev);
out:
if (err)
mddev_put(mddev);
--
2.28.0

2020-09-09 00:50:38

by Song Liu

Subject: Re: [PATCH 15/19] md: use bdev_check_media_change

On Tue, Sep 8, 2020 at 7:55 AM Christoph Hellwig <[email protected]> wrote:
>
> The md driver does not have a ->revalidate_disk method, so it can just
> use bdev_check_media_change without any additional changes.
>
> Signed-off-by: Christoph Hellwig <[email protected]>
> Reviewed-by: Johannes Thumshirn <[email protected]>

Acked-by: Song Liu <[email protected]>

> ---
> drivers/md/md.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 9562ef598ae1f4..27ed61197014ef 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -7848,7 +7848,7 @@ static int md_open(struct block_device *bdev, fmode_t mode)
> atomic_inc(&mddev->openers);
> mutex_unlock(&mddev->open_mutex);
>
> - check_disk_change(bdev);
> + bdev_check_media_change(bdev);
> out:
> if (err)
> mddev_put(mddev);
> --
> 2.28.0
>

2020-09-09 07:40:25

by Hannes Reinecke

Subject: Re: [PATCH 15/19] md: use bdev_check_media_change

On 9/8/20 4:53 PM, Christoph Hellwig wrote:
> The md driver does not have a ->revalidate_disk method, so it can just
> use bdev_check_media_change without any additional changes.
>
> Signed-off-by: Christoph Hellwig <[email protected]>
> Reviewed-by: Johannes Thumshirn <[email protected]>
> ---
> drivers/md/md.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 9562ef598ae1f4..27ed61197014ef 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -7848,7 +7848,7 @@ static int md_open(struct block_device *bdev, fmode_t mode)
> atomic_inc(&mddev->openers);
> mutex_unlock(&mddev->open_mutex);
>
> - check_disk_change(bdev);
> + bdev_check_media_change(bdev);
> out:
> if (err)
> mddev_put(mddev);
>
Reviewed-by: Hannes Reinecke <[email protected]>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
[email protected] +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer