2022-08-31 04:15:17

by zhounan

[permalink] [raw]
Subject: [PATCH] dm: Fix spelling mistake in comments

From: zhounan <[email protected]>

Fix spelling of dones't in comments.

Signed-off-by: zhounan <[email protected]>
---
drivers/md/raid5-cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
index f4e1cc1ece43..683fd4adde17 100644
--- a/drivers/md/raid5-cache.c
+++ b/drivers/md/raid5-cache.c
@@ -125,7 +125,7 @@ struct r5l_log {
* reclaimed. if it's 0, reclaim spaces
* used by io_units which are in
* IO_UNIT_STRIPE_END state (eg, reclaim
- * dones't wait for specific io_unit
+ * doesn't wait for specific io_unit
* switching to IO_UNIT_STRIPE_END
* state) */
wait_queue_head_t iounit_wait;
--
2.27.0


2022-09-19 19:08:16

by Song Liu

[permalink] [raw]
Subject: Re: [PATCH] dm: Fix spelling mistake in comments

On Tue, Aug 30, 2022 at 8:30 PM zhoun <[email protected]> wrote:
>
> From: zhounan <[email protected]>
>
> Fix spelling of dones't in comments.
>
> Signed-off-by: zhounan <[email protected]>

Please use your full name in the commit log. Also, please update the commit
message with more specific information, like:

md: Fix spelling mistake in comments of r5l_log

Fix spelling of "dones't" in comments.

Thanks,
Song

> ---
> drivers/md/raid5-cache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
> index f4e1cc1ece43..683fd4adde17 100644
> --- a/drivers/md/raid5-cache.c
> +++ b/drivers/md/raid5-cache.c
> @@ -125,7 +125,7 @@ struct r5l_log {
> * reclaimed. if it's 0, reclaim spaces
> * used by io_units which are in
> * IO_UNIT_STRIPE_END state (eg, reclaim
> - * dones't wait for specific io_unit
> + * doesn't wait for specific io_unit
> * switching to IO_UNIT_STRIPE_END
> * state) */
> wait_queue_head_t iounit_wait;
> --
> 2.27.0
>

2022-09-20 01:37:52

by zhounan

[permalink] [raw]
Subject: Re: [PATCH] dm: Fix spelling mistake in comments

Thank you for your suggestion and I will send a fixed version again.

2022-09-20 01:40:54

by zhounan

[permalink] [raw]
Subject: [PATCH] dm: Fix spelling mistake in comments

From: zhounan <[email protected]>

Fix spelling of dones't in comments.

Signed-off-by: zhounan <[email protected]>
---
drivers/md/raid5-cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
index f4e1cc1ece43..683fd4adde17 100644
--- a/drivers/md/raid5-cache.c
+++ b/drivers/md/raid5-cache.c
@@ -125,7 +125,7 @@ struct r5l_log {
* reclaimed. if it's 0, reclaim spaces
* used by io_units which are in
* IO_UNIT_STRIPE_END state (eg, reclaim
- * dones't wait for specific io_unit
+ * doesn't wait for specific io_unit
* switching to IO_UNIT_STRIPE_END
* state) */
wait_queue_head_t iounit_wait;
--
2.27.0

2022-09-20 12:18:52

by Paul Menzel

[permalink] [raw]
Subject: Re: [PATCH] dm: Fix spelling mistake in comments

Dear Zhou,


Am 20.09.22 um 03:28 schrieb Zhou nan:
> From: zhounan <[email protected]>

You missed the comment about using your full name.

$ git config --global user.name "Zhou Nan"
$ git commit --amend --author="Zhou Nan <[email protected]>"

> Fix spelling of dones't in comments.

… in one comment.

(Also in summary.)

> Signed-off-by: zhounan <[email protected]>
> ---
> drivers/md/raid5-cache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
> index f4e1cc1ece43..683fd4adde17 100644
> --- a/drivers/md/raid5-cache.c
> +++ b/drivers/md/raid5-cache.c
> @@ -125,7 +125,7 @@ struct r5l_log {
> * reclaimed. if it's 0, reclaim spaces
> * used by io_units which are in
> * IO_UNIT_STRIPE_END state (eg, reclaim
> - * dones't wait for specific io_unit
> + * doesn't wait for specific io_unit
> * switching to IO_UNIT_STRIPE_END
> * state) */
> wait_queue_head_t iounit_wait;

The rest looks good.


Kind regards,

Paul