2023-04-04 03:08:45

by Bagas Sanjaya

[permalink] [raw]
Subject: Re: [PATCH v7] tty: fix hang on tty device with no_room set

On 4/4/23 09:49, Bagas Sanjaya wrote:
> On Fri, Mar 17, 2023 at 10:24:07AM +0800, [email protected] wrote:
>> We have met a hang on pty device, the reader was blocking
>> at epoll on master side, the writer was sleeping at wait_woken
>> inside n_tty_write on slave side, and the write buffer on
>> tty_port was full, we found that the reader and writer would
>> never be woken again and blocked forever.
>
> Where do you find this hanging pty? Seems like the wording makes me
> confused. Maybe you mean "It is possible to hang pty device. In that
> case, ..."
>

Oops, I forgot to Cc: LKML.

--
An old man doll... just what I always wanted! - Clara


2023-04-04 07:04:09

by caelli

[permalink] [raw]
Subject: Re: [PATCH v7] tty: fix hang on tty device with no_room set

> Where do you find this hanging pty? Seems like the wording makes me
> confused. Maybe you mean "It is possible to hang pty device. In that
> case, ..."

Thanks for your reply, I will correct messages like this:

"It is possible to hang pty devices in this case, the reader
was blocking at epoll on master side, the writer was ..."

Bagas Sanjaya <[email protected]> 于2023年4月4日周二 10:55写道:
>
> On 4/4/23 09:49, Bagas Sanjaya wrote:
> > On Fri, Mar 17, 2023 at 10:24:07AM +0800, [email protected] wrote:
> >> We have met a hang on pty device, the reader was blocking
> >> at epoll on master side, the writer was sleeping at wait_woken
> >> inside n_tty_write on slave side, and the write buffer on
> >> tty_port was full, we found that the reader and writer would
> >> never be woken again and blocked forever.
> >
> > Where do you find this hanging pty? Seems like the wording makes me
> > confused. Maybe you mean "It is possible to hang pty device. In that
> > case, ..."
> >
>
> Oops, I forgot to Cc: LKML.
>
> --
> An old man doll... just what I always wanted! - Clara
>