2006-05-26 21:26:38

by Stephen Hemminger

[permalink] [raw]
Subject: [PATCH] hrtimer: export symbols

I want to use the hrtimer's in the netem (Network Emulator) qdisc.
But the necessary symbols aren't exported for module use.

Signed-off-by: Stephen Hemminger <[email protected]>
--- linux-2.6.orig/kernel/hrtimer.c 2006-04-27 11:12:53.000000000 -0700
+++ linux-2.6/kernel/hrtimer.c 2006-05-26 14:21:37.000000000 -0700
@@ -456,6 +456,7 @@

return ret;
}
+EXPORT_SYMBOL_GPL(hrtimer_start);

/**
* hrtimer_try_to_cancel - try to deactivate a timer
@@ -484,6 +485,7 @@
return ret;

}
+EXPORT_SYMBOL_GPL(hrtimer_try_to_cancel);

/**
* hrtimer_cancel - cancel a timer and wait for the handler to finish.
@@ -504,6 +506,7 @@
cpu_relax();
}
}
+EXPORT_SYMBOL_GPL(hrtimer_cancel);

/**
* hrtimer_get_remaining - get remaining time for the timer
@@ -522,6 +525,7 @@

return rem;
}
+EXPORT_SYMBOL_GPL(hrtimer_get_remaining);

#ifdef CONFIG_NO_IDLE_HZ
/**
@@ -580,6 +584,7 @@
timer->base = &bases[clock_id];
timer->node.rb_parent = HRTIMER_INACTIVE;
}
+EXPORT_SYMBOL_GPL(hrtimer_init);

/**
* hrtimer_get_res - get the timer resolution for a clock
@@ -599,6 +604,7 @@

return 0;
}
+EXPORT_SYMBOL_GPL(hrtimer_get_res);

/*
* Expire the per base hrtimer-queue:


2006-05-30 18:47:12

by Stone, Joshua I

[permalink] [raw]
Subject: RE: [PATCH] hrtimer: export symbols

On Fri, 26 May 2006 14:26:31 -0700, Stephen Hemminger wrote:
> I want to use the hrtimer's in the netem (Network Emulator) qdisc.
> But the necessary symbols aren't exported for module use.

I second this request -- we would like to use hrtimers in SystemTap
modules. The patch that Stephen provided would be sufficient for our
use as well.

I requested this a few months ago, and it was rejected on grounds that
the API was not yet stable enough for export. I hope that now it has
had time to settle so that modules may use the new API.

Thanks,

Josh Stone