2019-12-11 19:29:06

by Brendan Higgins

Subject: [PATCH v1 3/7] net: axienet: add unspecified HAS_IOMEM dependency

Currently CONFIG_XILINX_AXI_EMAC=y implicitly depends on
CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:

ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.o: in function `axienet_probe':
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1680: undefined reference to `devm_ioremap_resource'
ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1779: undefined reference to `devm_ioremap_resource'
ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1789: undefined reference to `devm_ioremap_resource'

Fix the build error by adding the unspecified dependency.

Reported-by: Brendan Higgins <[email protected]>
Signed-off-by: Brendan Higgins <[email protected]>
---
drivers/net/ethernet/xilinx/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/xilinx/Kconfig b/drivers/net/ethernet/xilinx/Kconfig
index 6304ebd8b5c69..b1a285e693756 100644
--- a/drivers/net/ethernet/xilinx/Kconfig
+++ b/drivers/net/ethernet/xilinx/Kconfig
@@ -25,6 +25,7 @@ config XILINX_EMACLITE

config XILINX_AXI_EMAC
tristate "Xilinx 10/100/1000 AXI Ethernet support"
+ depends on HAS_IOMEM
select PHYLINK
---help---
This driver supports the 10/100/1000 Ethernet from Xilinx for the
--
2.24.0.525.g8f36a354ae-goog

2019-12-12 05:46:05

by Radhey Shyam Pandey

Subject: RE: [PATCH v1 3/7] net: axienet: add unspecified HAS_IOMEM dependency

> -----Original Message-----
> From: Brendan Higgins <[email protected]>
> Sent: Thursday, December 12, 2019 12:58 AM
> To: [email protected]; [email protected];
> [email protected]; David S. Miller
> <[email protected]>; Michal Simek <[email protected]>; Radhey
> Shyam Pandey <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; Brendan Higgins <[email protected]>;
> [email protected]; [email protected]
> Subject: [PATCH v1 3/7] net: axienet: add unspecified HAS_IOMEM
> dependency
>
> Currently CONFIG_XILINX_AXI_EMAC=y implicitly depends on
> CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we
> get
> the following build error:
>
> ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.o: in function
> `axienet_probe':
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1680: undefined reference
> to `devm_ioremap_resource'
> ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1779: undefined
> reference to `devm_ioremap_resource'
> ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1789: undefined
> reference to `devm_ioremap_resource'
>
> Fix the build error by adding the unspecified dependency.
>
> Reported-by: Brendan Higgins <[email protected]>
> Signed-off-by: Brendan Higgins <[email protected]>
Reviewed-by: Radhey Shyam Pandey <[email protected]>
Thanks!

> ---
> drivers/net/ethernet/xilinx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/xilinx/Kconfig
> b/drivers/net/ethernet/xilinx/Kconfig
> index 6304ebd8b5c69..b1a285e693756 100644
> --- a/drivers/net/ethernet/xilinx/Kconfig
> +++ b/drivers/net/ethernet/xilinx/Kconfig
> @@ -25,6 +25,7 @@ config XILINX_EMACLITE
>
> config XILINX_AXI_EMAC
> tristate "Xilinx 10/100/1000 AXI Ethernet support"
> + depends on HAS_IOMEM
> select PHYLINK
> ---help---
> This driver supports the 10/100/1000 Ethernet from Xilinx for the
> --
> 2.24.0.525.g8f36a354ae-goog