2020-04-24 05:20:31

by Alexandru Ardelean

[permalink] [raw]
Subject: [RFC PATCH 0/4] iio: scan_mask rework to track enabled channels on per-channel basis

From my side, I'll admit that the specific use-cases for these patches
are a bit outside of my scope of understanding.
I did my best to re-apply them on a newer tree, and dig-up the
information from the ADI tree [where they've been living for a while
now].

Also, I don't have any idea if there was a prior discussion about this.
I could not find anything on a quick search.

I'm hoping that the author would have some input on them/

Hence the RFC.

Lars-Peter Clausen (4):
iio: Move scan mask management to the core
iio: hw_consumer: use new scanmask functions
iio: Allow channels to share storage elements
iio: Track enabled channels on a per channel basis

drivers/iio/buffer/industrialio-buffer-cb.c | 17 ++--
drivers/iio/buffer/industrialio-hw-consumer.c | 19 +++-
drivers/iio/industrialio-buffer.c | 98 +++++++++++++------
drivers/iio/industrialio-core.c | 27 +++--
drivers/iio/inkern.c | 30 ++++++
include/linux/iio/buffer_impl.h | 3 +
include/linux/iio/consumer.h | 12 +++
7 files changed, 154 insertions(+), 52 deletions(-)

--
2.17.1


2020-04-24 07:53:44

by Nuno Sa

[permalink] [raw]
Subject: RE: [RFC PATCH 0/4] iio: scan_mask rework to track enabled channels on per-channel basis

> From: [email protected] <[email protected]>
> On Behalf Of Alexandru Ardelean
> Sent: Freitag, 24. April 2020 07:18
> To: [email protected]; [email protected]
> Cc: [email protected]; [email protected]; Ardelean, Alexandru
> <[email protected]>
> Subject: [RFC PATCH 0/4] iio: scan_mask rework to track enabled channels on
> per-channel basis
>
>
> From my side, I'll admit that the specific use-cases for these patches
> are a bit outside of my scope of understanding.
> I did my best to re-apply them on a newer tree, and dig-up the
> information from the ADI tree [where they've been living for a while
> now].
>
> Also, I don't have any idea if there was a prior discussion about this.
> I could not find anything on a quick search.
>
> I'm hoping that the author would have some input on them/
>
> Hence the RFC.
>

Yeah, I remember I stumbled against this when looking to some of our drivers where we have (IIRC) a 16
channel ADC where 1 channel occupies 1 bit. I just gave a quick look on this and it looks good to me
(naturally it needs a deeper look :D). I just have one remark/question inline in patch 4.

- Nuno S?