2019-10-16 13:39:54

by Ooi, Joyce

Subject: [PATCH] arm64: defconfig: add JFFS FS support in defconfig

This patch adds JFFS2 FS support and remove QSPI Sector 4K size force in
the default defconfig

Signed-off-by: Ooi, Joyce <[email protected]>
---
arch/arm64/configs/defconfig | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index c9adae4..6080c6e 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -860,3 +860,5 @@ CONFIG_DEBUG_KERNEL=y
# CONFIG_DEBUG_PREEMPT is not set
# CONFIG_FTRACE is not set
CONFIG_MEMTEST=y
+CONFIG_JFFS2_FS=y
+CONFIG_MTD_SPI_NOR_USE_4K_SECTORS=n
--
1.9.1

2019-10-16 15:07:58

by Vladimir Murzin

Subject: Re: [PATCH] arm64: defconfig: add JFFS FS support in defconfig

On 10/16/19 10:35 AM, Ooi, Joyce wrote:
> This patch adds JFFS2 FS support and remove QSPI Sector 4K size force in
> the default defconfig
>
> Signed-off-by: Ooi, Joyce <[email protected]>
> ---
> arch/arm64/configs/defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index c9adae4..6080c6e 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -860,3 +860,5 @@ CONFIG_DEBUG_KERNEL=y
> # CONFIG_DEBUG_PREEMPT is not set
> # CONFIG_FTRACE is not set
> CONFIG_MEMTEST=y
> +CONFIG_JFFS2_FS=y
> +CONFIG_MTD_SPI_NOR_USE_4K_SECTORS=n
^^^^
This is incorrect syntax for disabling config option. Correct one is

# CONFIG_MTD_SPI_NOR_USE_4K_SECTORS is not set

However, it looks to me you want to remove it from defconfig rather than
force it to be unset.

Cheers
Vladimir

2019-10-18 09:43:04

by Ooi, Joyce

Subject: RE: [PATCH] arm64: defconfig: add JFFS FS support in defconfig

> -----Original Message-----
> From: Vladimir Murzin [mailto:[email protected]]
> Sent: Wednesday, October 16, 2019 7:46 PM
> To: Ooi, Joyce <[email protected]>; Catalin Marinas
> <[email protected]>; Will Deacon <[email protected]>; Dinh Nguyen
> <[email protected]>
> Cc: Tan, Ley Foon <[email protected]>; Anson Huang
> <[email protected]>; Arnd Bergmann <[email protected]>; Ong, Hean Loong
> <[email protected]>; See, Chin Liang <[email protected]>;
> [email protected]; Maxime Ripard <[email protected]>; Bjorn
> Andersson <[email protected]>; Marcin Juszkiewicz
> <[email protected]>; Jagan Teki <[email protected]>;
> Olof Johansson <[email protected]>; Leonard Crestez
> <[email protected]>; Shawn Guo <[email protected]>; linux-arm-
> [email protected]
> Subject: Re: [PATCH] arm64: defconfig: add JFFS FS support in defconfig
>
> On 10/16/19 10:35 AM, Ooi, Joyce wrote:
> > This patch adds JFFS2 FS support and remove QSPI Sector 4K size force
> > in the default defconfig
> >
> > Signed-off-by: Ooi, Joyce <[email protected]>
> > ---
> > arch/arm64/configs/defconfig | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/configs/defconfig
> > b/arch/arm64/configs/defconfig index c9adae4..6080c6e 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -860,3 +860,5 @@ CONFIG_DEBUG_KERNEL=y #
> CONFIG_DEBUG_PREEMPT is
> > not set # CONFIG_FTRACE is not set CONFIG_MEMTEST=y
> > +CONFIG_JFFS2_FS=y
> > +CONFIG_MTD_SPI_NOR_USE_4K_SECTORS=n
> ^^^^
> This is incorrect syntax for disabling config option. Correct one is
>
> # CONFIG_MTD_SPI_NOR_USE_4K_SECTORS is not set
Okay, will do that.

>
> However, it looks to me you want to remove it from defconfig rather than force
> it to be unset.
>
> Cheers
> Vladimir