2019-10-18 09:49:27

by Ooi, Joyce

Subject: [PATCHv2] arm64: defconfig: add JFFS FS support in defconfig

This patch adds JFFS2 FS support and remove QSPI Sector 4K size force in
the default defconfig

Signed-off-by: Ooi, Joyce <[email protected]>
---
v2: disable CONFIG_MTD_SPI_NOR_USE_4K_SECTORS using the correct syntax
---
arch/arm64/configs/defconfig | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index c9adae4..6080c6e 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -860,3 +860,5 @@ CONFIG_DEBUG_KERNEL=y
# CONFIG_DEBUG_PREEMPT is not set
# CONFIG_FTRACE is not set
CONFIG_MEMTEST=y
+CONFIG_JFFS2_FS=y
+# CONFIG_MTD_SPI_NOR_USE_4K_SECTORS is not set
--
1.9.1

2019-10-21 15:57:56

by Dinh Nguyen

Subject: Re: [PATCHv2] arm64: defconfig: add JFFS FS support in defconfig

On 10/17/19 1:28 AM, Ooi, Joyce wrote:
> This patch adds JFFS2 FS support and remove QSPI Sector 4K size force in
> the default defconfig
>
> Signed-off-by: Ooi, Joyce <[email protected]>
> ---
> v2: disable CONFIG_MTD_SPI_NOR_USE_4K_SECTORS using the correct syntax
> ---
> arch/arm64/configs/defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index c9adae4..6080c6e 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -860,3 +860,5 @@ CONFIG_DEBUG_KERNEL=y
> # CONFIG_DEBUG_PREEMPT is not set
> # CONFIG_FTRACE is not set
> CONFIG_MEMTEST=y
> +CONFIG_JFFS2_FS=y
> +# CONFIG_MTD_SPI_NOR_USE_4K_SECTORS is not set
>

Can you explain why you're removing CONFIG_MTD_SPI_NOR_USE_4K_SECTORS?

Dinh

2019-10-23 20:27:20

by Ooi, Joyce

Subject: RE: [PATCHv2] arm64: defconfig: add JFFS FS support in defconfig

> -----Original Message-----
> From: Dinh Nguyen <[email protected]>
> Sent: Monday, October 21, 2019 11:57 PM
> To: Ooi, Joyce <[email protected]>; Vladimir Murzin
> <[email protected]>; Catalin Marinas <[email protected]>; Will
> Deacon <[email protected]>
> Cc: Shawn Guo <[email protected]>; Olof Johansson <[email protected]>;
> Maxime Ripard <[email protected]>; Bjorn Andersson
> <[email protected]>; Arnd Bergmann <[email protected]>; Jagan Teki
> <[email protected]>; Anson Huang <[email protected]>;
> Leonard Crestez <[email protected]>; Marcin Juszkiewicz
> <[email protected]>; [email protected]; linux-
> [email protected]; Ong, Hean Loong <[email protected]>; See,
> Chin Liang <[email protected]>; Tan, Ley Foon
> <[email protected]>
> Subject: Re: [PATCHv2] arm64: defconfig: add JFFS FS support in defconfig
>
>
>
> On 10/17/19 1:28 AM, Ooi, Joyce wrote:
> > This patch adds JFFS2 FS support and remove QSPI Sector 4K size force
> > in the default defconfig
> >
> > Signed-off-by: Ooi, Joyce <[email protected]>
> > ---
> > v2: disable CONFIG_MTD_SPI_NOR_USE_4K_SECTORS using the correct syntax
> > ---
> > arch/arm64/configs/defconfig | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/configs/defconfig
> > b/arch/arm64/configs/defconfig index c9adae4..6080c6e 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -860,3 +860,5 @@ CONFIG_DEBUG_KERNEL=y #
> CONFIG_DEBUG_PREEMPT is
> > not set # CONFIG_FTRACE is not set CONFIG_MEMTEST=y
> > +CONFIG_JFFS2_FS=y
> > +# CONFIG_MTD_SPI_NOR_USE_4K_SECTORS is not set
> >
>
> Can you explain why you're removing
> CONFIG_MTD_SPI_NOR_USE_4K_SECTORS?
Removing CONFIG_MTD_SPI_NOR_USE_4K_SECTORS will fix errors like this:
[ 1.905772] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985 not found at 0x00000f90: 0x00bf instead
[ 1.915275] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985 not found at 0x00000f94: 0x6abb instead

I'll add this explanation in the commit message.
>
> Dinh