2012-10-22 09:17:25

by Wei Yongjun

Subject: [PATCH] aoe: remove unused variable in resend()

From: Wei Yongjun <[email protected]>

The variable ah is initialized but never used
otherwise, so remove the unused variable.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/block/aoe/aoecmd.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
index 3804a0a..812eb8a 100644
--- a/drivers/block/aoe/aoecmd.c
+++ b/drivers/block/aoe/aoecmd.c
@@ -425,7 +425,6 @@ resend(struct aoedev *d, struct frame *f)
struct sk_buff *skb;
struct sk_buff_head queue;
struct aoe_hdr *h;
- struct aoe_atahdr *ah;
struct aoetgt *t;
char buf[128];
u32 n;
@@ -440,7 +439,6 @@ resend(struct aoedev *d, struct frame *f)
return;
}
h = (struct aoe_hdr *) skb_mac_header(skb);
- ah = (struct aoe_atahdr *) (h+1);

snprintf(buf, sizeof buf,
"%15s e%ld.%d oldtag=%08x@%08lx newtag=%08x s=%pm d=%pm nout=%d\n",

2012-10-22 19:56:39

by Ed L. Cashin

Subject: Re: [PATCH] aoe: remove unused variable in resend()

Looks good, thanks.

On Oct 22, 2012, at 5:17 AM, Wei Yongjun wrote:

> From: Wei Yongjun <[email protected]>
>
> The variable ah is initialized but never used
> otherwise, so remove the unused variable.
>
> dpatch engine is used to auto generate this patch.
> (https://github.com/weiyj/dpatch)
>
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
> drivers/block/aoe/aoecmd.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
> index 3804a0a..812eb8a 100644
> --- a/drivers/block/aoe/aoecmd.c
> +++ b/drivers/block/aoe/aoecmd.c
> @@ -425,7 +425,6 @@ resend(struct aoedev *d, struct frame *f)
> struct sk_buff *skb;
> struct sk_buff_head queue;
> struct aoe_hdr *h;
> - struct aoe_atahdr *ah;
> struct aoetgt *t;
> char buf[128];
> u32 n;
> @@ -440,7 +439,6 @@ resend(struct aoedev *d, struct frame *f)
> return;
> }
> h = (struct aoe_hdr *) skb_mac_header(skb);
> - ah = (struct aoe_atahdr *) (h+1);
>
> snprintf(buf, sizeof buf,
> "%15s e%ld.%d oldtag=%08x@%08lx newtag=%08x s=%pm d=%pm nout=%d\n",
>

--
Ed Cashin
[email protected]