2021-02-03 10:31:17

by DooHyun Hwang

Subject: [PATCH] scsi: ufs: print the counter of each event history

Since only print the recorded event history list,
add to print the counter value.

Signed-off-by: DooHyun Hwang <[email protected]>
---
drivers/scsi/ufs/ufshcd.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 721f55db181f..1ea920aeb701 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -451,6 +451,8 @@ static void ufshcd_print_evt(struct ufs_hba *hba, u32 id,

if (!found)
dev_err(hba->dev, "No record of %s\n", err_name);
+ else
+ dev_err(hba->dev, "%s: total cnt=%llu\n", err_name, e->cnt);
}

static void ufshcd_print_evt_hist(struct ufs_hba *hba)
--
2.29.0

2021-02-05 08:23:08

by Avri Altman

Subject: RE: [PATCH] scsi: ufs: print the counter of each event history

>
>
> Since only print the recorded event history list,
> add to print the counter value.
>
> Signed-off-by: DooHyun Hwang <[email protected]>
Reviewed-by: Avri Altman <[email protected]>

Btw, You have the counter now in ufs-debugfs as well.

Thanks,
Avri

2021-02-05 08:38:50

by DooHyun Hwang

Subject: RE: [PATCH] scsi: ufs: print the counter of each event history

>>
>> Since only print the recorded event history list, add to print the
>> counter value.
>>
>> Signed-off-by: DooHyun Hwang <[email protected]>
>Reviewed-by: Avri Altman <[email protected]>
>
>Btw, You have the counter now in ufs-debugfs as well.
>
>Thanks,
>Avri

Thank you for your review and information.

I hope to be able to check the counter value in kernel log as well.

Thank you.
DooHyun Hwang.

2021-02-09 03:26:28

by Martin K. Petersen

Subject: Re: [PATCH] scsi: ufs: print the counter of each event history

DooHyun,

> Since only print the recorded event history list, add to print the
> counter value.

Applied to 5.12/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering