2020-09-30 01:16:12

by Sergey Senozhatsky

Subject: [PATCH] media: ov2740: select regmap

Fix OV2740 build breakage by selecting REGMAP_I2C config:

ov2740.c:1011:23: error: variable has incomplete type 'struct regmap_config'
struct regmap_config regmap_config = { };
^
ov2740.c:1011:9: note: forward declaration of 'struct regmap_config'
struct regmap_config regmap_config = { };
^
ov2740.c:1028:11: error: implicit declaration of function 'devm_regmap_init_i2c'
regmap = devm_regmap_init_i2c(client, &regmap_config);

Signed-off-by: Sergey Senozhatsky <[email protected]>
---
drivers/media/i2c/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 878f66ef2719..c64326ca331c 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -877,6 +877,7 @@ config VIDEO_OV2740
select MEDIA_CONTROLLER
select VIDEO_V4L2_SUBDEV_API
select V4L2_FWNODE
+ select REGMAP_I2C
help
This is a Video4Linux2 sensor driver for the OmniVision
OV2740 camera.
--
2.28.0

2020-10-06 03:24:17

by Cao, Bingbu

Subject: RE: [PATCH] media: ov2740: select regmap

Sergey, thanks for your patch.

Reviewed-by: Bingbu Cao <[email protected]>

________________________
BRs,
Bingbu Cao


> -----Original Message-----
> From: Sergey Senozhatsky <[email protected]>
> Sent: Wednesday, September 30, 2020 9:13 AM
> To: Mauro Carvalho Chehab <[email protected]>; Cao, Bingbu
> <[email protected]>
> Cc: Sakari Ailus <[email protected]>; [email protected];
> [email protected]; Sergey Senozhatsky
> <[email protected]>
> Subject: [PATCH] media: ov2740: select regmap
>
> Fix OV2740 build breakage by selecting REGMAP_I2C config:
>
> ov2740.c:1011:23: error: variable has incomplete type 'struct regmap_config'
> struct regmap_config regmap_config = { };
> ^
> ov2740.c:1011:9: note: forward declaration of 'struct regmap_config'
> struct regmap_config regmap_config = { };
> ^
> ov2740.c:1028:11: error: implicit declaration of function
> 'devm_regmap_init_i2c'
> regmap = devm_regmap_init_i2c(client, &regmap_config);
>
> Signed-off-by: Sergey Senozhatsky <[email protected]>
> ---
> drivers/media/i2c/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index
> 878f66ef2719..c64326ca331c 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -877,6 +877,7 @@ config VIDEO_OV2740
> select MEDIA_CONTROLLER
> select VIDEO_V4L2_SUBDEV_API
> select V4L2_FWNODE
> + select REGMAP_I2C
> help
> This is a Video4Linux2 sensor driver for the OmniVision
> OV2740 camera.
> --
> 2.28.0