2021-07-01 10:44:28

by Lukas Bulwahn

Subject: [PATCH] RDMA/irdma: make spdxcheck.py happy

Commit 48d6b3336a9f ("RDMA/irdma: Add ABI definitions") adds
./include/uapi/rdma/irdma-abi.h with an additional unneeded closing
bracket at the end of the SPDX-License-Identifier line.

Hence, ./scripts/spdxcheck.py complains:

include/uapi/rdma/irdma-abi.h: 1:77 Syntax error: )

Remove that closing bracket to make spdxcheck.py happy.

Signed-off-by: Lukas Bulwahn <[email protected]>
---
applies cleanly on next-20210701

Mustafa, Shiraz, please ack.
Jason, please pick this minor non-urgent patch into your rdma tree.

include/uapi/rdma/irdma-abi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/rdma/irdma-abi.h b/include/uapi/rdma/irdma-abi.h
index 26b638a7ad97..a7085e092d34 100644
--- a/include/uapi/rdma/irdma-abi.h
+++ b/include/uapi/rdma/irdma-abi.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: (GPL-2.0 WITH Linux-syscall-note) OR Linux-OpenIB) */
+/* SPDX-License-Identifier: (GPL-2.0 WITH Linux-syscall-note) OR Linux-OpenIB */
/*
* Copyright (c) 2006 - 2021 Intel Corporation. All rights reserved.
* Copyright (c) 2005 Topspin Communications. All rights reserved.
--
2.17.1

2021-07-07 16:59:43

by Nikolova, Tatyana E

Subject: RE: [PATCH] RDMA/irdma: make spdxcheck.py happy

> -----Original Message-----
> From: Lukas Bulwahn <[email protected]>
> Sent: Thursday, July 1, 2021 3:41 AM
> To: Ismail, Mustafa <[email protected]>; Saleem, Shiraz
> <[email protected]>; Doug Ledford <[email protected]>; Jason
> Gunthorpe <[email protected]>; [email protected]
> Cc: [email protected]; [email protected]; Lukas
> Bulwahn <[email protected]>
> Subject: [PATCH] RDMA/irdma: make spdxcheck.py happy
>
> Commit 48d6b3336a9f ("RDMA/irdma: Add ABI definitions") adds
> ./include/uapi/rdma/irdma-abi.h with an additional unneeded closing
> bracket at the end of the SPDX-License-Identifier line.
>
> Hence, ./scripts/spdxcheck.py complains:
>
> include/uapi/rdma/irdma-abi.h: 1:77 Syntax error: )
>
> Remove that closing bracket to make spdxcheck.py happy.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
> ---
> applies cleanly on next-20210701
>
> Mustafa, Shiraz, please ack.
> Jason, please pick this minor non-urgent patch into your rdma tree.
>
> include/uapi/rdma/irdma-abi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/rdma/irdma-abi.h b/include/uapi/rdma/irdma-abi.h
> index 26b638a7ad97..a7085e092d34 100644
> --- a/include/uapi/rdma/irdma-abi.h
> +++ b/include/uapi/rdma/irdma-abi.h
> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: (GPL-2.0 WITH Linux-syscall-note) OR Linux-
> OpenIB) */
> +/* SPDX-License-Identifier: (GPL-2.0 WITH Linux-syscall-note) OR
> +Linux-OpenIB */
> /*
> * Copyright (c) 2006 - 2021 Intel Corporation. All rights reserved.
> * Copyright (c) 2005 Topspin Communications. All rights reserved.
> --
> 2.17.1

Acked-by: Tatyana Nikolova <[email protected]>

2021-07-12 18:05:37

by Jason Gunthorpe

Subject: Re: [PATCH] RDMA/irdma: make spdxcheck.py happy

On Thu, Jul 01, 2021 at 12:41:27PM +0200, Lukas Bulwahn wrote:
> Commit 48d6b3336a9f ("RDMA/irdma: Add ABI definitions") adds
> ./include/uapi/rdma/irdma-abi.h with an additional unneeded closing
> bracket at the end of the SPDX-License-Identifier line.
>
> Hence, ./scripts/spdxcheck.py complains:
>
> include/uapi/rdma/irdma-abi.h: 1:77 Syntax error: )
>
> Remove that closing bracket to make spdxcheck.py happy.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
> Acked-by: Tatyana Nikolova <[email protected]>
> ---
> applies cleanly on next-20210701
>
> Mustafa, Shiraz, please ack.
> Jason, please pick this minor non-urgent patch into your rdma tree.

Applied to for-rc

Thanks,
Jason