2022-08-26 19:25:25

by Marcel Ziswiler

[permalink] [raw]
Subject: [PATCH v1 0/5] ARM: arm64: dts/clk: imx: indentation permission whitespace cleanup 2

From: Marcel Ziswiler <[email protected]>


While further synchronising them imx device trees with U-Boot I stumbled
over more checkpatch warnings. This series addresses those trivial
indentation, file permission and/or whitespace cleanups.


Marcel Ziswiler (5):
ARM: dts: imx6sl: use tabs for code indent
ARM: dts: imx6sx-udoo-neo: don't use multiple blank lines
arm64: dts: imx8ulp: no executable source file permission
clk: imx6sll: add proper spdx license identifier
dt-bindings: imx8ulp: clock: no spaces before tabs

arch/arm/boot/dts/imx6sl.dtsi | 20 +++++++++----------
arch/arm/boot/dts/imx6sx-udoo-neo.dtsi | 14 ++++++-------
.../boot/dts/freescale/imx8ulp-pinfunc.h | 0
include/dt-bindings/clock/imx6sll-clock.h | 2 +-
include/dt-bindings/clock/imx8ulp-clock.h | 4 ++--
5 files changed, 19 insertions(+), 21 deletions(-)
mode change 100755 => 100644 arch/arm64/boot/dts/freescale/imx8ulp-pinfunc.h

--
2.36.1


2022-08-26 19:25:26

by Marcel Ziswiler

[permalink] [raw]
Subject: [PATCH v1 1/5] ARM: dts: imx6sl: use tabs for code indent

From: Marcel Ziswiler <[email protected]>

This fixes the following error:

arch/arm/boot/dts/imx6sl.dtsi:714: error: code indent should use tabs
where possible

Signed-off-by: Marcel Ziswiler <[email protected]>
---

arch/arm/boot/dts/imx6sl.dtsi | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
index 06a515121dfc..271f4b971a83 100644
--- a/arch/arm/boot/dts/imx6sl.dtsi
+++ b/arch/arm/boot/dts/imx6sl.dtsi
@@ -61,10 +61,10 @@ cpu0: cpu@0 {
<792000 1175000>,
<396000 975000>;
fsl,soc-operating-points =
- /* ARM kHz SOC-PU uV */
- <996000 1225000>,
- <792000 1175000>,
- <396000 1175000>;
+ /* ARM kHz SOC-PU uV */
+ <996000 1225000>,
+ <792000 1175000>,
+ <396000 1175000>;
clock-latency = <61036>; /* two CLK32 periods */
#cooling-cells = <2>;
clocks = <&clks IMX6SL_CLK_ARM>, <&clks IMX6SL_CLK_PLL2_PFD2>,
@@ -222,7 +222,7 @@ ecspi4: spi@2014000 {

uart5: serial@2018000 {
compatible = "fsl,imx6sl-uart",
- "fsl,imx6q-uart", "fsl,imx21-uart";
+ "fsl,imx6q-uart", "fsl,imx21-uart";
reg = <0x02018000 0x4000>;
interrupts = <0 30 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6SL_CLK_UART>,
@@ -235,7 +235,7 @@ uart5: serial@2018000 {

uart1: serial@2020000 {
compatible = "fsl,imx6sl-uart",
- "fsl,imx6q-uart", "fsl,imx21-uart";
+ "fsl,imx6q-uart", "fsl,imx21-uart";
reg = <0x02020000 0x4000>;
interrupts = <0 26 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6SL_CLK_UART>,
@@ -248,7 +248,7 @@ uart1: serial@2020000 {

uart2: serial@2024000 {
compatible = "fsl,imx6sl-uart",
- "fsl,imx6q-uart", "fsl,imx21-uart";
+ "fsl,imx6q-uart", "fsl,imx21-uart";
reg = <0x02024000 0x4000>;
interrupts = <0 27 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6SL_CLK_UART>,
@@ -309,7 +309,7 @@ ssi3: ssi@2030000 {

uart3: serial@2034000 {
compatible = "fsl,imx6sl-uart",
- "fsl,imx6q-uart", "fsl,imx21-uart";
+ "fsl,imx6q-uart", "fsl,imx21-uart";
reg = <0x02034000 0x4000>;
interrupts = <0 28 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6SL_CLK_UART>,
@@ -322,7 +322,7 @@ uart3: serial@2034000 {

uart4: serial@2038000 {
compatible = "fsl,imx6sl-uart",
- "fsl,imx6q-uart", "fsl,imx21-uart";
+ "fsl,imx6q-uart", "fsl,imx21-uart";
reg = <0x02038000 0x4000>;
interrupts = <0 29 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6SL_CLK_UART>,
@@ -711,7 +711,7 @@ pd_pu: power-domain@1 {
#power-domain-cells = <0>;
power-supply = <&reg_pu>;
clocks = <&clks IMX6SL_CLK_GPU2D_OVG>,
- <&clks IMX6SL_CLK_GPU2D_PODF>;
+ <&clks IMX6SL_CLK_GPU2D_PODF>;
};

pd_disp: power-domain@2 {
--
2.36.1

2022-08-26 19:25:30

by Marcel Ziswiler

[permalink] [raw]
Subject: [PATCH v1 4/5] clk: imx6sll: add proper spdx license identifier

From: Marcel Ziswiler <[email protected]>

This fixes the following error:

include/dt-bindings/clock/imx6sll-clock.h:1: warning: Improper SPDX
comment style for 'include/dt-bindings/clock/imx6sll-clock.h', please
use '/*' instead
include/dt-bindings/clock/imx6sll-clock.h:1: warning: Missing or
malformed SPDX-License-Identifier tag in line 1

Signed-off-by: Marcel Ziswiler <[email protected]>
---

include/dt-bindings/clock/imx6sll-clock.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/dt-bindings/clock/imx6sll-clock.h b/include/dt-bindings/clock/imx6sll-clock.h
index f446710fe63d..494fd0c37fb5 100644
--- a/include/dt-bindings/clock/imx6sll-clock.h
+++ b/include/dt-bindings/clock/imx6sll-clock.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Copyright (C) 2016 Freescale Semiconductor, Inc.
* Copyright 2017-2018 NXP.
--
2.36.1

2022-08-26 19:25:44

by Marcel Ziswiler

[permalink] [raw]
Subject: [PATCH v1 5/5] dt-bindings: imx8ulp: clock: no spaces before tabs

From: Marcel Ziswiler <[email protected]>

This fixes the following warnings:

include/dt-bindings/clock/imx8ulp-clock.h:204: warning: please, no space
before tabs
include/dt-bindings/clock/imx8ulp-clock.h:215: warning: please, no space
before tabs

Signed-off-by: Marcel Ziswiler <[email protected]>

---

include/dt-bindings/clock/imx8ulp-clock.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/dt-bindings/clock/imx8ulp-clock.h b/include/dt-bindings/clock/imx8ulp-clock.h
index 953ecfe8ebcc..827404fadf5c 100644
--- a/include/dt-bindings/clock/imx8ulp-clock.h
+++ b/include/dt-bindings/clock/imx8ulp-clock.h
@@ -201,7 +201,7 @@
#define IMX8ULP_CLK_SAI7 2
#define IMX8ULP_CLK_SPDIF 3
#define IMX8ULP_CLK_ISI 4
-#define IMX8ULP_CLK_CSI_REGS 5
+#define IMX8ULP_CLK_CSI_REGS 5
#define IMX8ULP_CLK_PCTLD 6
#define IMX8ULP_CLK_CSI 7
#define IMX8ULP_CLK_DSI 8
@@ -212,7 +212,7 @@
#define IMX8ULP_CLK_GPU2D 13
#define IMX8ULP_CLK_GPU3D 14
#define IMX8ULP_CLK_DC_NANO 15
-#define IMX8ULP_CLK_CSI_CLK_UI 16
+#define IMX8ULP_CLK_CSI_CLK_UI 16
#define IMX8ULP_CLK_CSI_CLK_ESC 17
#define IMX8ULP_CLK_RGPIOD 18
#define IMX8ULP_CLK_DMA2_MP 19
--
2.36.1

2022-08-26 19:26:21

by Marcel Ziswiler

[permalink] [raw]
Subject: [PATCH v1 3/5] arm64: dts: imx8ulp: no executable source file permission

From: Marcel Ziswiler <[email protected]>

This fixes the following error:

arch/arm64/boot/dts/freescale/imx8ulp-pinfunc.h: error: do not set
execute permissions for source files

Signed-off-by: Marcel Ziswiler <[email protected]>
---

arch/arm64/boot/dts/freescale/imx8ulp-pinfunc.h | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100755 => 100644 arch/arm64/boot/dts/freescale/imx8ulp-pinfunc.h

diff --git a/arch/arm64/boot/dts/freescale/imx8ulp-pinfunc.h b/arch/arm64/boot/dts/freescale/imx8ulp-pinfunc.h
old mode 100755
new mode 100644
--
2.36.1

2022-08-27 17:57:03

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v1 5/5] dt-bindings: imx8ulp: clock: no spaces before tabs

On 26/08/2022 22:22, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <[email protected]>
>
> This fixes the following warnings:
>
> include/dt-bindings/clock/imx8ulp-clock.h:204: warning: please, no space
> before tabs
> include/dt-bindings/clock/imx8ulp-clock.h:215: warning: please, no space
> before tabs
>
> Signed-off-by: Marcel Ziswiler <[email protected]>


Acked-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof

2022-08-29 05:49:39

by Peng Fan

[permalink] [raw]
Subject: RE: [PATCH v1 3/5] arm64: dts: imx8ulp: no executable source file permission

> Subject: [PATCH v1 3/5] arm64: dts: imx8ulp: no executable source file
> permission
>
> From: Marcel Ziswiler <[email protected]>
>
> This fixes the following error:
>
> arch/arm64/boot/dts/freescale/imx8ulp-pinfunc.h: error: do not set
> execute permissions for source files
>
> Signed-off-by: Marcel Ziswiler <[email protected]>

Acked-by: Peng Fan <[email protected]>
> ---
>
> arch/arm64/boot/dts/freescale/imx8ulp-pinfunc.h | 0
> 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 =>
> 100644 arch/arm64/boot/dts/freescale/imx8ulp-pinfunc.h
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp-pinfunc.h
> b/arch/arm64/boot/dts/freescale/imx8ulp-pinfunc.h
> old mode 100755
> new mode 100644
> --
> 2.36.1

2022-08-29 09:53:33

by Abel Vesa

[permalink] [raw]
Subject: Re: [PATCH v1 5/5] dt-bindings: imx8ulp: clock: no spaces before tabs

On 22-08-26 21:22:52, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <[email protected]>
>
> This fixes the following warnings:
>
> include/dt-bindings/clock/imx8ulp-clock.h:204: warning: please, no space
> before tabs
> include/dt-bindings/clock/imx8ulp-clock.h:215: warning: please, no space
> before tabs
>
> Signed-off-by: Marcel Ziswiler <[email protected]>

Reviewed-by: Abel Vesa <[email protected]>

>
> ---
>
> include/dt-bindings/clock/imx8ulp-clock.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/dt-bindings/clock/imx8ulp-clock.h b/include/dt-bindings/clock/imx8ulp-clock.h
> index 953ecfe8ebcc..827404fadf5c 100644
> --- a/include/dt-bindings/clock/imx8ulp-clock.h
> +++ b/include/dt-bindings/clock/imx8ulp-clock.h
> @@ -201,7 +201,7 @@
> #define IMX8ULP_CLK_SAI7 2
> #define IMX8ULP_CLK_SPDIF 3
> #define IMX8ULP_CLK_ISI 4
> -#define IMX8ULP_CLK_CSI_REGS 5
> +#define IMX8ULP_CLK_CSI_REGS 5
> #define IMX8ULP_CLK_PCTLD 6
> #define IMX8ULP_CLK_CSI 7
> #define IMX8ULP_CLK_DSI 8
> @@ -212,7 +212,7 @@
> #define IMX8ULP_CLK_GPU2D 13
> #define IMX8ULP_CLK_GPU3D 14
> #define IMX8ULP_CLK_DC_NANO 15
> -#define IMX8ULP_CLK_CSI_CLK_UI 16
> +#define IMX8ULP_CLK_CSI_CLK_UI 16
> #define IMX8ULP_CLK_CSI_CLK_ESC 17
> #define IMX8ULP_CLK_RGPIOD 18
> #define IMX8ULP_CLK_DMA2_MP 19
> --
> 2.36.1
>

2022-08-29 10:38:24

by Abel Vesa

[permalink] [raw]
Subject: Re: [PATCH v1 4/5] clk: imx6sll: add proper spdx license identifier

On 22-08-26 21:22:51, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <[email protected]>
>
> This fixes the following error:
>
> include/dt-bindings/clock/imx6sll-clock.h:1: warning: Improper SPDX
> comment style for 'include/dt-bindings/clock/imx6sll-clock.h', please
> use '/*' instead
> include/dt-bindings/clock/imx6sll-clock.h:1: warning: Missing or
> malformed SPDX-License-Identifier tag in line 1
>
> Signed-off-by: Marcel Ziswiler <[email protected]>

Reviewed-by: Abel Vesa <[email protected]>

> ---
>
> include/dt-bindings/clock/imx6sll-clock.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/clock/imx6sll-clock.h b/include/dt-bindings/clock/imx6sll-clock.h
> index f446710fe63d..494fd0c37fb5 100644
> --- a/include/dt-bindings/clock/imx6sll-clock.h
> +++ b/include/dt-bindings/clock/imx6sll-clock.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> * Copyright (C) 2016 Freescale Semiconductor, Inc.
> * Copyright 2017-2018 NXP.
> --
> 2.36.1
>

2022-08-30 21:17:20

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v1 4/5] clk: imx6sll: add proper spdx license identifier

On Fri, 26 Aug 2022 21:22:51 +0200, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <[email protected]>
>
> This fixes the following error:
>
> include/dt-bindings/clock/imx6sll-clock.h:1: warning: Improper SPDX
> comment style for 'include/dt-bindings/clock/imx6sll-clock.h', please
> use '/*' instead
> include/dt-bindings/clock/imx6sll-clock.h:1: warning: Missing or
> malformed SPDX-License-Identifier tag in line 1
>
> Signed-off-by: Marcel Ziswiler <[email protected]>
> ---
>
> include/dt-bindings/clock/imx6sll-clock.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Acked-by: Rob Herring <[email protected]>

2022-09-05 02:27:16

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH v1 1/5] ARM: dts: imx6sl: use tabs for code indent

On Fri, Aug 26, 2022 at 09:22:48PM +0200, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <[email protected]>
>
> This fixes the following error:
>
> arch/arm/boot/dts/imx6sl.dtsi:714: error: code indent should use tabs
> where possible
>
> Signed-off-by: Marcel Ziswiler <[email protected]>

Applied, thanks!

2022-09-05 02:32:45

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH v1 3/5] arm64: dts: imx8ulp: no executable source file permission

On Fri, Aug 26, 2022 at 09:22:50PM +0200, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <[email protected]>
>
> This fixes the following error:
>
> arch/arm64/boot/dts/freescale/imx8ulp-pinfunc.h: error: do not set
> execute permissions for source files
>
> Signed-off-by: Marcel Ziswiler <[email protected]>

Applied, thanks!