Any comments would be appreciated.
Description: Use msleep_interruptible() instead of schedule_timeout() to
guarantee the task delays as expected.
Signed-off-by: Nishanth Aravamudan <[email protected]>
Looks fine to me.
Signed-off-by: Christoph Lameter <[email protected]>
Signed-off-by: Maximilian Attems <[email protected]>
---
linux-2.6.9-rc2-bk7-max/drivers/char/pcxx.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)
diff -puN drivers/char/pcxx.c~msleep_interruptible-drivers_char_pcxx drivers/char/pcxx.c
--- linux-2.6.9-rc2-bk7/drivers/char/pcxx.c~msleep_interruptible-drivers_char_pcxx 2004-09-21 21:08:15.000000000 +0200
+++ linux-2.6.9-rc2-bk7-max/drivers/char/pcxx.c 2004-09-21 21:08:15.000000000 +0200
@@ -555,8 +555,7 @@ static void pcxe_close(struct tty_struct
#endif
if(info->blocked_open) {
if(info->close_delay) {
- current->state = TASK_INTERRUPTIBLE;
- schedule_timeout(info->close_delay);
+ msleep_interruptible(jiffies_to_msecs(info->close_delay));
}
wake_up_interruptible(&info->open_wait);
}
_