2004-09-23 20:47:15

by maximilian attems

[permalink] [raw]
Subject: [patch 20/21] media/tda9887: replace schedule_timeout() with msleep_interruptible()




Any comments would be appreciated.

Description: Use msleep_interruptible() instead of schedule_timeout()
to guarantee the task delays as expected.

Signed-off-by: Nishanth Aravamudan <[email protected]>

Signed-off-by: Maximilian Attems <[email protected]>
---

linux-2.6.9-rc2-bk7-max/drivers/media/video/tda9887.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff -puN drivers/media/video/tda9887.c~msleep_interruptible-drivers_media_video_tda9887 drivers/media/video/tda9887.c
--- linux-2.6.9-rc2-bk7/drivers/media/video/tda9887.c~msleep_interruptible-drivers_media_video_tda9887 2004-09-21 21:17:10.000000000 +0200
+++ linux-2.6.9-rc2-bk7-max/drivers/media/video/tda9887.c 2004-09-21 21:17:10.000000000 +0200
@@ -6,6 +6,7 @@
#include <linux/init.h>
#include <linux/errno.h>
#include <linux/slab.h>
+#include <linux/delay.h>

#include <media/audiochip.h>
#include <media/tuner.h>
@@ -543,8 +544,7 @@ static int tda9887_configure(struct tda9
printk(PREFIX "i2c i/o error: rc == %d (should be 4)\n",rc);

if (debug > 2) {
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(HZ);
+ msleep_interruptible(1000);
tda9887_status(t);
}
return 0;
_