2004-09-23 20:59:26

by maximilian attems

[permalink] [raw]
Subject: [patch 2/2] ieee1394/sbp2: replace schedule_timeout() with msleep_interruptible()




Any comments would be appreciated.

Description: Uses msleep_interruptible() in place of schedule_timeout()
to guarantee the task delays as expected.

Signed-off-by: Nishanth Aravamudan <[email protected]>

Signed-off-by: Maximilian Attems <[email protected]>
---

linux-2.6.9-rc2-bk7-max/drivers/ieee1394/sbp2.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)

diff -puN drivers/ieee1394/sbp2.c~msleep_interruptible-drivers_ieee1394_sbp2 drivers/ieee1394/sbp2.c
--- linux-2.6.9-rc2-bk7/drivers/ieee1394/sbp2.c~msleep_interruptible-drivers_ieee1394_sbp2 2004-09-21 21:16:32.000000000 +0200
+++ linux-2.6.9-rc2-bk7-max/drivers/ieee1394/sbp2.c 2004-09-21 21:16:32.000000000 +0200
@@ -357,8 +357,7 @@ static int sbp2util_down_timeout(atomic_
int i;

for (i = timeout; (i > 0 && atomic_read(done) == 0); i-= HZ/10) {
- set_current_state(TASK_INTERRUPTIBLE);
- if (schedule_timeout(HZ/10)) /* 100ms */
+ if (msleep_interruptible(100)) /* 100ms */
return(1);
}
return ((i > 0) ? 0:1);
_