2004-10-30 22:52:52

by maximilian attems

Subject: [patch 2/8] pcmcia/yenta_socket: replace schedule_timeout() with msleep()

Any comments would be appreciated.

Description: Use msleep() instead of schedule_timeout()
to guarantee the task delays as expected.

Signed-off-by: Nishanth Aravamudan <[email protected]>
Signed-off-by: Maximilian Attems <[email protected]>

---

linux-2.6.10-rc1-max/drivers/pcmcia/yenta_socket.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)

diff -puN drivers/pcmcia/yenta_socket.c~msleep-drivers_net_irda_pcmcia_yenta_socket drivers/pcmcia/yenta_socket.c
--- linux-2.6.10-rc1/drivers/pcmcia/yenta_socket.c~msleep-drivers_net_irda_pcmcia_yenta_socket 2004-10-24 17:04:56.000000000 +0200
+++ linux-2.6.10-rc1-max/drivers/pcmcia/yenta_socket.c 2004-10-24 17:04:56.000000000 +0200
@@ -827,8 +827,7 @@ static int yenta_probe_cb_irq(struct yen
cb_writel(socket, CB_SOCKET_MASK, CB_CSTSMASK);
cb_writel(socket, CB_SOCKET_FORCE, CB_FCARDSTS);

- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(HZ/10);
+ msleep(100);

/* disable interrupts */
cb_writel(socket, CB_SOCKET_MASK, 0);
_

2004-11-20 09:34:40

by Russell King

Subject: Re: [patch 2/8] pcmcia/yenta_socket: replace schedule_timeout() with msleep()

On Sun, Oct 31, 2004 at 12:47:02AM +0200, [email protected] wrote:
> Any comments would be appreciated.

Applied, thanks.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core