Use list_for_each_entry_safe to make code more readable.
Compile tested.
Signed-off-by: Domen Puncer <[email protected]>
Signed-off-by: Maximilian Attems <[email protected]>
---
linux-2.6.10-rc2-bk4-max/fs/coda/psdev.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff -puN fs/coda/psdev.c~list-for-each-entry-safe-fs_coda_psdev fs/coda/psdev.c
--- linux-2.6.10-rc2-bk4/fs/coda/psdev.c~list-for-each-entry-safe-fs_coda_psdev 2004-11-19 17:15:05.000000000 +0100
+++ linux-2.6.10-rc2-bk4-max/fs/coda/psdev.c 2004-11-19 17:15:05.000000000 +0100
@@ -310,8 +310,7 @@ static int coda_psdev_open(struct inode
static int coda_psdev_release(struct inode * inode, struct file * file)
{
struct venus_comm *vcp = (struct venus_comm *) file->private_data;
- struct upc_req *req;
- struct list_head *lh, *next;
+ struct upc_req *req, *tmp;
lock_kernel();
if ( !vcp->vc_inuse ) {
@@ -326,8 +325,7 @@ static int coda_psdev_release(struct ino
}
/* Wakeup clients so they can return. */
- list_for_each_safe(lh, next, &vcp->vc_pending) {
- req = list_entry(lh, struct upc_req, uc_chain);
+ list_for_each_entry_safe(req, tmp, &vcp->vc_pending, uc_chain) {
/* Async requests need to be freed here */
if (req->uc_flags & REQ_ASYNC) {
CODA_FREE(req->uc_data, sizeof(struct coda_in_hdr));
_