2006-09-20 11:22:13

by Metathronius Galabant

Subject: [PATCH]: cciss - remove unneeded spaces in output for attached volumes (resend)

Hi,

please see the following patch against the cciss driver (HP/Compaq
SmartArray Controllers).
It removes the awkwards spaces after the "=" when displaying the
geometry of the attached volumes.

Before:
cciss: using DAC cycles
blocks= 286734240 block_size= 512
heads= 255, sectors= 32, cylinders= 35139

After:
cciss: using DAC cycles
blocks=286734240 block_size=512
heads=255, sectors=32, cylinders=35139


The following is against 2.6.18-rc6 (and I hope gmail doesn't corrupt
the inline patch).
Cheers,
M.


Signed-off-by: Metathronius Galabant <[email protected]>

diff -ru linux-2.6.18-rc6/drivers/block/cciss.c
linux-2.6.18-rc6-f/drivers/block/cciss.c
--- linux-2.6.18-rc6/drivers/block/cciss.c 2006-09-11
15:57:54.000000000 +0200
+++ linux-2.6.18-rc6-f/drivers/block/cciss.c 2006-09-11
16:32:42.000000000 +0200
@@ -1934,7 +1934,7 @@
} else { /* Get geometry failed */
printk(KERN_WARNING "cciss: reading geometry failed\n");
}
- printk(KERN_INFO " heads= %d, sectors= %d, cylinders= %d\n\n",
+ printk(KERN_INFO " heads=%d, sectors=%d, cylinders=%d\n\n",
drv->heads, drv->sectors, drv->cylinders);
}

@@ -1962,7 +1962,7 @@
*total_size = 0;
*block_size = BLOCK_SIZE;
}
- printk(KERN_INFO " blocks= %u block_size= %d\n",
+ printk(KERN_INFO " blocks=%u block_size=%d\n",
*total_size, *block_size);
return;
}

2006-09-20 13:48:05

by Mike Miller

Subject: RE: [PATCH]: cciss - remove unneeded spaces in output for attached volumes (resend)

> -----Original Message-----
> From: Metathronius Galabant [mailto:[email protected]]
> Sent: Wednesday, September 20, 2006 6:22 AM
> To: ISS StorageDev
> Cc: [email protected]; [email protected]
> Subject: [PATCH]: cciss - remove unneeded spaces in output
> for attached volumes (resend)
>
> Hi,
>
> please see the following patch against the cciss driver
> (HP/Compaq SmartArray Controllers).
> It removes the awkwards spaces after the "=" when displaying
> the geometry of the attached volumes.
>
> Before:
> cciss: using DAC cycles
> blocks= 286734240 block_size= 512
> heads= 255, sectors= 32, cylinders= 35139
>
> After:
> cciss: using DAC cycles
> blocks=286734240 block_size=512
> heads=255, sectors=32, cylinders=35139
>
>
> The following is against 2.6.18-rc6 (and I hope gmail doesn't
> corrupt the inline patch).
> Cheers,
> M.
>
>
> Signed-off-by: Metathronius Galabant <[email protected]>

Acked-by: Mike Miller <[email protected]>

>
> diff -ru linux-2.6.18-rc6/drivers/block/cciss.c
> linux-2.6.18-rc6-f/drivers/block/cciss.c
> --- linux-2.6.18-rc6/drivers/block/cciss.c 2006-09-11
> 15:57:54.000000000 +0200
> +++ linux-2.6.18-rc6-f/drivers/block/cciss.c 2006-09-11
> 16:32:42.000000000 +0200
> @@ -1934,7 +1934,7 @@
> } else { /* Get geometry failed */
> printk(KERN_WARNING "cciss: reading geometry
> failed\n");
> }
> - printk(KERN_INFO " heads= %d, sectors= %d,
> cylinders= %d\n\n",
> + printk(KERN_INFO " heads=%d, sectors=%d,
> cylinders=%d\n\n",
> drv->heads, drv->sectors, drv->cylinders); }
>
> @@ -1962,7 +1962,7 @@
> *total_size = 0;
> *block_size = BLOCK_SIZE;
> }
> - printk(KERN_INFO " blocks= %u block_size= %d\n",
> + printk(KERN_INFO " blocks=%u block_size=%d\n",
> *total_size, *block_size);
> return;
> }
>