Drop #address-cells and #size-cells, which are not required by the
gpio-keys binding documentation, as button sub-nodes are not devices.
Rename sub-nodes to avoid new dtc unit address warnings when copied.
While at it, adopt the dashes convention for the node name.
Reported-by: Julien Chauveau <[email protected]>
Cc: Julien Chauveau <[email protected]>
Cc: Javier Martinez Canillas <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Signed-off-by: Andreas Färber <[email protected]>
---
v1 -> v2:
* Changed node name from underscore to dash
* Inserted white lines
* Renamed sub-nodes (Geert, Julien)
Documentation/devicetree/bindings/input/gpio-keys.txt | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/input/gpio-keys.txt b/Documentation/devicetree/bindings/input/gpio-keys.txt
index 21641236c095..a94940481e55 100644
--- a/Documentation/devicetree/bindings/input/gpio-keys.txt
+++ b/Documentation/devicetree/bindings/input/gpio-keys.txt
@@ -32,17 +32,17 @@ Optional subnode-properties:
Example nodes:
- gpio_keys {
+ gpio-keys {
compatible = "gpio-keys";
- #address-cells = <1>;
- #size-cells = <0>;
autorepeat;
- button@21 {
+
+ up {
label = "GPIO Key UP";
linux,code = <103>;
gpios = <&gpio1 0 1>;
};
- button@22 {
+
+ down {
label = "GPIO Key DOWN";
linux,code = <108>;
interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
--
2.6.2
Hello Andreas,
On Wed, Mar 16, 2016 at 8:53 AM, Andreas Färber <[email protected]> wrote:
> Drop #address-cells and #size-cells, which are not required by the
> gpio-keys binding documentation, as button sub-nodes are not devices.
>
> Rename sub-nodes to avoid new dtc unit address warnings when copied.
>
> While at it, adopt the dashes convention for the node name.
>
> Reported-by: Julien Chauveau <[email protected]>
> Cc: Julien Chauveau <[email protected]>
> Cc: Javier Martinez Canillas <[email protected]>
> Cc: Geert Uytterhoeven <[email protected]>
> Signed-off-by: Andreas Färber <[email protected]>
> ---
Patch looks good to me.
Reviewed-by: Javier Martinez Canillas <[email protected]>
Best regards,
Javier
> Le 16 mars 2016 à 15:47, Javier Martinez Canillas <[email protected]> a écrit :
>
> Hello Andreas,
>
> On Wed, Mar 16, 2016 at 8:53 AM, Andreas Färber <[email protected]> wrote:
>> Drop #address-cells and #size-cells, which are not required by the
>> gpio-keys binding documentation, as button sub-nodes are not devices.
>>
>> Rename sub-nodes to avoid new dtc unit address warnings when copied.
>>
>> While at it, adopt the dashes convention for the node name.
>>
>> Reported-by: Julien Chauveau <[email protected]>
>> Cc: Julien Chauveau <[email protected]>
>> Cc: Javier Martinez Canillas <[email protected]>
>> Cc: Geert Uytterhoeven <[email protected]>
>> Signed-off-by: Andreas Färber <[email protected]>
>> ---
>
> Patch looks good to me.
>
> Reviewed-by: Javier Martinez Canillas <[email protected]>
I agree.
Reviewed-by: Julien Chauveau <[email protected]>
On Wed, Mar 16, 2016 at 10:55:53PM +0100, Julien Chauveau wrote:
>
> > Le 16 mars 2016 ? 15:47, Javier Martinez Canillas <[email protected]> a ?crit :
> >
> > Hello Andreas,
> >
> > On Wed, Mar 16, 2016 at 8:53 AM, Andreas F?rber <[email protected]> wrote:
> >> Drop #address-cells and #size-cells, which are not required by the
> >> gpio-keys binding documentation, as button sub-nodes are not devices.
> >>
> >> Rename sub-nodes to avoid new dtc unit address warnings when copied.
> >>
> >> While at it, adopt the dashes convention for the node name.
> >>
> >> Reported-by: Julien Chauveau <[email protected]>
> >> Cc: Julien Chauveau <[email protected]>
> >> Cc: Javier Martinez Canillas <[email protected]>
> >> Cc: Geert Uytterhoeven <[email protected]>
> >> Signed-off-by: Andreas F?rber <[email protected]>
> >> ---
> >
> > Patch looks good to me.
> >
> > Reviewed-by: Javier Martinez Canillas <[email protected]>
>
> I agree.
>
> Reviewed-by: Julien Chauveau <[email protected]>
Applied, thank you.
--
Dmitry
On Wed, Mar 16, 2016 at 12:53:29PM +0100, Andreas F?rber wrote:
> Drop #address-cells and #size-cells, which are not required by the
> gpio-keys binding documentation, as button sub-nodes are not devices.
>
> Rename sub-nodes to avoid new dtc unit address warnings when copied.
>
> While at it, adopt the dashes convention for the node name.
>
> Reported-by: Julien Chauveau <[email protected]>
> Cc: Julien Chauveau <[email protected]>
> Cc: Javier Martinez Canillas <[email protected]>
> Cc: Geert Uytterhoeven <[email protected]>
> Signed-off-by: Andreas F?rber <[email protected]>
Applied, thanks.
Rob
> ---
> v1 -> v2:
> * Changed node name from underscore to dash
> * Inserted white lines
> * Renamed sub-nodes (Geert, Julien)
>
> Documentation/devicetree/bindings/input/gpio-keys.txt | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/input/gpio-keys.txt b/Documentation/devicetree/bindings/input/gpio-keys.txt
> index 21641236c095..a94940481e55 100644
> --- a/Documentation/devicetree/bindings/input/gpio-keys.txt
> +++ b/Documentation/devicetree/bindings/input/gpio-keys.txt
> @@ -32,17 +32,17 @@ Optional subnode-properties:
>
> Example nodes:
>
> - gpio_keys {
> + gpio-keys {
> compatible = "gpio-keys";
> - #address-cells = <1>;
> - #size-cells = <0>;
> autorepeat;
> - button@21 {
> +
> + up {
> label = "GPIO Key UP";
> linux,code = <103>;
> gpios = <&gpio1 0 1>;
> };
> - button@22 {
> +
> + down {
> label = "GPIO Key DOWN";
> linux,code = <108>;
> interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
> --
> 2.6.2
>
Hello Rob,
On Tue, Apr 19, 2016 at 6:13 PM, Rob Herring <[email protected]> wrote:
> On Wed, Mar 16, 2016 at 12:53:29PM +0100, Andreas Färber wrote:
>> Drop #address-cells and #size-cells, which are not required by the
>> gpio-keys binding documentation, as button sub-nodes are not devices.
>>
>> Rename sub-nodes to avoid new dtc unit address warnings when copied.
>>
>> While at it, adopt the dashes convention for the node name.
>>
>> Reported-by: Julien Chauveau <[email protected]>
>> Cc: Julien Chauveau <[email protected]>
>> Cc: Javier Martinez Canillas <[email protected]>
>> Cc: Geert Uytterhoeven <[email protected]>
>> Signed-off-by: Andreas Färber <[email protected]>
>
> Applied, thanks.
>
Dmitry already applied this patch in the input tree.
> Rob
>
Best regards,
Javier