2005-01-05 22:52:32

by Kyle Moffett

[permalink] [raw]
Subject: [PATCH] [2.6] Clean up useless 8250 siig functions and header



Cheers,
Kyle Moffett

-----BEGIN GEEK CODE BLOCK-----
Version: 3.12
GCM/CS/IT/U d- s++: a18 C++++>$ UB/L/X/*++++(+)>$ P+++(++++)>$
L++++(+++) E W++(+) N+++(++) o? K? w--- O? M++ V? PS+() PE+(-) Y+
PGP+++ t+(+++) 5 X R? tv-(--) b++++(++) DI+ D+ G e->++++$ h!*()>++$ r
!y?(-)
------END GEEK CODE BLOCK------


Attachments:
(No filename) (0.00 B)

2005-01-14 12:01:46

by Andrey Panin

[permalink] [raw]
Subject: Re: [PATCH] [2.6] Clean up useless 8250 siig functions and header

On 005, 01 05, 2005 at 05:52:14PM -0500, Kyle Moffett wrote:
> This removes two simple siig functions that should just be integrated
> into the calling code.

Good idea, wrong patch. You deleted wrapper code, but actual init
functions left not exported for use by parport_serial module.
Even worse, they are left static, so monilithic kernel build will
not work too :/

Did you compiled the kernel with your patch applied ?

Please use attached patch instead.

--
Andrey Panin | Linux and UNIX system administrator
[email protected] | PGP key: wwwkeys.pgp.net


Attachments:
(No filename) (0.00 B)
signature.asc (189.00 B)
Digital signature
Download all attachments

2005-01-14 12:22:43

by Kyle Moffett

[permalink] [raw]
Subject: Re: [PATCH] [2.6] Clean up useless 8250 siig functions and header

On Jan 14, 2005, at 07:01, Andrey Panin wrote:
> On 005, 01 05, 2005 at 05:52:14PM -0500, Kyle Moffett wrote:
>> This removes two simple siig functions that should just be integrated
>> into the calling code.
>
> Good idea, wrong patch. You deleted wrapper code, but actual init
> functions left not exported for use by parport_serial module.
> Even worse, they are left static, so monilithic kernel build will
> not work too :/

Oops, sorry!

> Did you compiled the kernel with your patch applied ?

Yes, but I think I managed to lose some changes somewhere in the
process of managing my patchset.

> Please use attached patch instead.

Thanks,
Kyle Moffett

-----BEGIN GEEK CODE BLOCK-----
Version: 3.12
GCM/CS/IT/U d- s++: a18 C++++>$ UB/L/X/*++++(+)>$ P+++(++++)>$
L++++(+++) E W++(+) N+++(++) o? K? w--- O? M++ V? PS+() PE+(-) Y+
PGP+++ t+(+++) 5 X R? tv-(--) b++++(++) DI+ D+ G e->++++$ h!*()>++$ r
!y?(-)
------END GEEK CODE BLOCK------