LinuxLists.cc - [PATCH] usb: missing parentheses in USE_NEW

2020-01-04 11:08:27

Subject: [PATCH] usb: missing parentheses in USE_NEW_SCHEME

accroding to bd0e6c9#diff-28615d62e1250eadc353d804f49bc6d6, will try old enumeration
scheme first for high speed devices. for example, when a high speed device pluged in,
line 2720 should expand to 0 at the first time. USE_NEW_SCHEME(0, 0 || 0 || 1) === 0.
but it wrongly expand to 1(alway expand to 1 for high speed device), and change
USE_NEW_SCHEME to USE_NEW_SCHEME((i) % 2 == (int)(scheme)) may be better ?

Acked-by: Alan Stern <[email protected]>
Signed-off-by: Qi Zhou <[email protected]>
---
drivers/usb/core/hub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index f229ad6952c0..7d17deca7021 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -2692,7 +2692,7 @@ static unsigned hub_is_wusb(struct usb_hub *hub)
#define SET_ADDRESS_TRIES 2
#define GET_DESCRIPTOR_TRIES 2
#define SET_CONFIG_TRIES (2 * (use_both_schemes + 1))
-#define USE_NEW_SCHEME(i, scheme) ((i) / 2 == (int)scheme)
+#define USE_NEW_SCHEME(i, scheme) ((i) / 2 == (int)(scheme))

#define HUB_ROOT_RESET_TIME 60 /* times are in msec */
#define HUB_SHORT_RESET_TIME 10
--
2.17.1

2020-01-04 11:47:54

by Greg Kroah-Hartman

[permalink] [raw]

Subject: Re: [PATCH] usb: missing parentheses in USE_NEW_SCHEME

On Sat, Jan 04, 2020 at 11:02:01AM +0000, atmgnd wrote:
> accroding to bd0e6c9#diff-28615d62e1250eadc353d804f49bc6d6, will try old enumeration
> scheme first for high speed devices. for example, when a high speed device pluged in,
> line 2720 should expand to 0 at the first time. USE_NEW_SCHEME(0, 0 || 0 || 1) === 0.
> but it wrongly expand to 1(alway expand to 1 for high speed device), and change
> USE_NEW_SCHEME to USE_NEW_SCHEME((i) % 2 == (int)(scheme)) may be better ?
>
> Acked-by: Alan Stern <[email protected]>
> Signed-off-by: Qi Zhou <[email protected]>
> ---
> drivers/usb/core/hub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index f229ad6952c0..7d17deca7021 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -2692,7 +2692,7 @@ static unsigned hub_is_wusb(struct usb_hub *hub)
> #define SET_ADDRESS_TRIES 2
> #define GET_DESCRIPTOR_TRIES 2
> #define SET_CONFIG_TRIES (2 * (use_both_schemes + 1))
> -#define USE_NEW_SCHEME(i, scheme) ((i) / 2 == (int)scheme)
> +#define USE_NEW_SCHEME(i, scheme) ((i) / 2 == (int)(scheme))
>
> #define HUB_ROOT_RESET_TIME 60 /* times are in msec */
> #define HUB_SHORT_RESET_TIME 10
> --
> 2.17.1
>
>

Much better, but your From: name does not match your signed-off-by name :(

2020-01-05 01:17:52

by atmgnd

[permalink] [raw]

Subject: Re: [PATCH] usb: missing parentheses in USE_NEW_SCHEME

Is that ok ? Ordinarily I dont use protonmail, only because outlook mail is blocked by kernel email system.
So I register this email to send plain/text emails.
I will resend it.

Sent with ProtonMail Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Saturday, January 4, 2020 7:46 PM, [email protected] <[email protected]> wrote:

> On Sat, Jan 04, 2020 at 11:02:01AM +0000, atmgnd wrote:
>
> > accroding to bd0e6c9#diff-28615d62e1250eadc353d804f49bc6d6, will try old enumeration
> > scheme first for high speed devices. for example, when a high speed device pluged in,
> > line 2720 should expand to 0 at the first time. USE_NEW_SCHEME(0, 0 || 0 || 1) === 0.
> > but it wrongly expand to 1(alway expand to 1 for high speed device), and change
> > USE_NEW_SCHEME to USE_NEW_SCHEME((i) % 2 == (int)(scheme)) may be better ?
> >
> > Acked-by: Alan Stern [email protected]
> > Signed-off-by: Qi Zhou [email protected]
> >
> > -----------------------------------------------------------------------------------------
> >
> > drivers/usb/core/hub.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> > index f229ad6952c0..7d17deca7021 100644
> > --- a/drivers/usb/core/hub.c
> > +++ b/drivers/usb/core/hub.c
> > @@ -2692,7 +2692,7 @@ static unsigned hub_is_wusb(struct usb_hub *hub)
> > #define SET_ADDRESS_TRIES 2
> > #define GET_DESCRIPTOR_TRIES 2
> > #define SET_CONFIG_TRIES (2 * (use_both_schemes + 1))
> > -#define USE_NEW_SCHEME(i, scheme) ((i) / 2 == (int)scheme)
> > +#define USE_NEW_SCHEME(i, scheme) ((i) / 2 == (int)(scheme))
> >
> > #define HUB_ROOT_RESET_TIME 60 /* times are in msec */
> > #define HUB_SHORT_RESET_TIME 10
> >
> > ---------------------------------------------------------------------------------------
> >
> > 2.17.1
>
> Much better, but your From: name does not match your signed-off-by name :(

2020-01-05 01:18:49

by atmgnd

[permalink] [raw]

Subject: Re: [PATCH] usb: missing parentheses in USE_NEW_SCHEME

2020-01-05 08:18:40

by Greg Kroah-Hartman

[permalink] [raw]

Subject: Re: [PATCH] usb: missing parentheses in USE_NEW_SCHEME

On Sun, Jan 05, 2020 at 01:15:41AM +0000, atmgnd wrote:
> Is that ok ? Ordinarily I dont use protonmail, only because outlook mail is blocked by kernel email system.
> So I register this email to send plain/text emails.
> I will resend it.

Just add a "From:" line in the first line of the changelog text to match
up with your "real" email address. The kernel and git documentation
should show this.

thanks,

greg k-h

2020-01-05 11:36:35

by atmgnd

[permalink] [raw]

Subject: Re: [PATCH] usb: missing parentheses in USE_NEW_SCHEME

I have already resend you a new patch with 'Signed-off-by: Qi Zhou <[email protected]>', Can you just use that one ? thanks.

Sent with ProtonMail Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Sunday, January 5, 2020 4:17 PM, [email protected] <[email protected]> wrote:

> On Sun, Jan 05, 2020 at 01:15:41AM +0000, atmgnd wrote:
>
> > Is that ok ? Ordinarily I dont use protonmail, only because outlook mail is blocked by kernel email system.
> > So I register this email to send plain/text emails.
> > I will resend it.
>
> Just add a "From:" line in the first line of the changelog text to match
> up with your "real" email address. The kernel and git documentation
> should show this.
>
> thanks,
>
> greg k-h

2020-01-08 16:44:34

by Greg Kroah-Hartman

[permalink] [raw]

Subject: Re: [PATCH] usb: missing parentheses in USE_NEW_SCHEME

On Sun, Jan 05, 2020 at 11:35:30AM +0000, atmgnd wrote:
> I have already resend you a new patch with 'Signed-off-by: Qi Zhou <[email protected]>', Can you just use that one ? thanks.

Ugh, I have to edit it by hand, but will do so.

Please work on fixing up your email system, 'git send-email' should work
with just about any MTA out there.

greg k-h