2022-03-11 07:15:16

by Haiyang Zhang

[permalink] [raw]
Subject: RE: [PATCH] net: netvsc: remove break after return



> -----Original Message-----
> From: Saurabh Sengar <[email protected]>
> Sent: Thursday, March 10, 2022 12:32 PM
> To: Saurabh Singh Sengar <[email protected]>; Haiyang Zhang <[email protected]>;
> KY Srinivasan <[email protected]>; Stephen Hemminger <[email protected]>;
> [email protected]; Dexuan Cui <[email protected]>; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]
> Subject: [PATCH] net: netvsc: remove break after return
>
> In function netvsc_process_raw_pkt for VM_PKT_DATA_USING_XFER_PAGES
> case there is already a 'return' statement which results 'break'
> as dead code
>
> Signed-off-by: Saurabh Sengar <[email protected]>
> ---
> drivers/net/hyperv/netvsc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
> index e675d10..9442f75 100644
> --- a/drivers/net/hyperv/netvsc.c
> +++ b/drivers/net/hyperv/netvsc.c
> @@ -1630,7 +1630,6 @@ static int netvsc_process_raw_pkt(struct hv_device *device,
>
> case VM_PKT_DATA_USING_XFER_PAGES:
> return netvsc_receive(ndev, net_device, nvchan, desc);
> - break;
>
> case VM_PKT_DATA_INBAND:

Thanks.
Reviewed-by: Haiyang Zhang <[email protected]>