2019-07-05 09:07:04

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v3] serial/8250: Add support for NI-Serial PXI/PXIe+485 devices

On Fri, Jul 05, 2019 at 01:33:49AM -0700, jeyentam wrote:
> Add support for NI-Serial PXIe-RS232, PXI-RS485 and PXIe-RS485 devices.
>
> Signed-off-by: Je Yen Tam <[email protected]>
> ---
> drivers/tty/serial/8250/8250_pci.c | 298 ++++++++++++++++++++++++++++-
> 1 file changed, 294 insertions(+), 4 deletions(-)

What changed from the previous versions?

Always put that below the --- line.

Please fix up and send a v4 with that information.

thanks,

greg k-h


2019-07-05 09:58:36

by Je Yen Tam

[permalink] [raw]
Subject: RE: Re: [PATCH v3] serial/8250: Add support for NI-Serial PXI/PXIe+485 devices

> On Fri, Jul 05, 2019 at 01:33:49AM -0700, jeyentam wrote:
> > Add support for NI-Serial PXIe-RS232, PXI-RS485 and PXIe-RS485 devices.
> >
> > Signed-off-by: Je Yen Tam <[email protected]>
> > ---
> > drivers/tty/serial/8250/8250_pci.c | 298 ++++++++++++++++++++++++++++-
> > 1 file changed, 294 insertions(+), 4 deletions(-)
>
> What changed from the previous versions?
>
> Always put that below the --- line.
>
> Please fix up and send a v4 with that information.

Ok, will do so.

>
> thanks,
>
> greg k-h

2019-07-11 16:37:59

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: Re: [PATCH v3] serial/8250: Add support for NI-Serial PXI/PXIe+485 devices

On Thu, Jul 11, 2019 at 04:01:28PM +0000, Je Yen Tam wrote:
> > > On Fri, Jul 05, 2019 at 01:33:49AM -0700, jeyentam wrote:
> > > > Add support for NI-Serial PXIe-RS232, PXI-RS485 and PXIe-RS485 devices.
> > > >
> > > > Signed-off-by: Je Yen Tam <[email protected]>
> > > > ---
> > > > drivers/tty/serial/8250/8250_pci.c | 298 ++++++++++++++++++++++++++++-
> > > > 1 file changed, 294 insertions(+), 4 deletions(-)
> > >
> > > What changed from the previous versions?
> > >
> > > Always put that below the --- line.
> > >
> > > Please fix up and send a v4 with that information.
> >
> > Ok, will do so.
>
> Hi, please be noted that a v4 is submitted and ready for review.

It is the middle of the merge window. I can't do anything with any
patches until after 5.3-rc1 is out, and then, give me a few weeks to
catch up on the pending backlog.

thanks,

greg k-h