2019-05-25 12:25:27

by Yue Haibing

Subject: [PATCH -next] MIPS: uprobes: remove set but not used variable 'epc'

Fixes gcc '-Wunused-but-set-variable' warning:

arch/mips/kernel/uprobes.c: In function 'arch_uprobe_pre_xol':
arch/mips/kernel/uprobes.c:115:17: warning: variable 'epc' set but not used [-Wunused-but-set-variable]

It's never used since introduction in
commit 40e084a506eb ("MIPS: Add uprobes support.")

Signed-off-by: YueHaibing <[email protected]>
---
arch/mips/kernel/uprobes.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/arch/mips/kernel/uprobes.c b/arch/mips/kernel/uprobes.c
index 4aaff3b3175c..6dbe4eab0a0e 100644
--- a/arch/mips/kernel/uprobes.c
+++ b/arch/mips/kernel/uprobes.c
@@ -112,9 +112,6 @@ int arch_uprobe_pre_xol(struct arch_uprobe *aup, struct pt_regs *regs)
*/
aup->resume_epc = regs->cp0_epc + 4;
if (insn_has_delay_slot((union mips_instruction) aup->insn[0])) {
- unsigned long epc;
-
- epc = regs->cp0_epc;
__compute_return_epc_for_insn(regs,
(union mips_instruction) aup->insn[0]);
aup->resume_epc = regs->cp0_epc;
--
2.17.1

2019-05-29 20:37:11

by Paul Burton

Subject: Re: [PATCH -next] MIPS: uprobes: remove set but not used variable 'epc'

Hello,

YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> arch/mips/kernel/uprobes.c: In function 'arch_uprobe_pre_xol':
> arch/mips/kernel/uprobes.c:115:17: warning: variable 'epc' set but not used [-Wunused-but-set-variable]
>
> It's never used since introduction in
> commit 40e084a506eb ("MIPS: Add uprobes support.")
>
> Signed-off-by: YueHaibing <[email protected]>

Applied to mips-fixes.

Thanks,
Paul

[ This message was auto-generated; if you believe anything is incorrect
then please email [email protected] to report it. ]