2022-03-17 21:51:43

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Fixes tag needs some work in the spi tree

Hi all,

In commit

ebc4cb43ea5a ("spi: Fix erroneous sgs value with min_t()")

Fixes tag

Fixes: commit 1a4e53d2fc4f68aa ("spi: Fix invalid sgs value")

has these problem(s):

- leading word 'commit' unexpected

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2022-03-18 16:52:32

by Biju Das

[permalink] [raw]
Subject: RE: linux-next: Fixes tag needs some work in the spi tree

Hi Stephen and Mark,

My bad, I have added Fixes tag at last minute and missed running
Check patch with that change.

Is it possible to manually fix this?

Regards,
Biju


> Subject: linux-next: Fixes tag needs some work in the spi tree
>
> Hi all,
>
> In commit
>
> ebc4cb43ea5a ("spi: Fix erroneous sgs value with min_t()")
>
> Fixes tag
>
> Fixes: commit 1a4e53d2fc4f68aa ("spi: Fix invalid sgs value")
>
> has these problem(s):
>
> - leading word 'commit' unexpected
>
> --
> Cheers,
> Stephen Rothwell

2022-03-18 17:00:42

by Biju Das

[permalink] [raw]
Subject: RE: linux-next: Fixes tag needs some work in the spi tree

Hi Mark,

> Subject: Re: linux-next: Fixes tag needs some work in the spi tree
>
> On Fri, Mar 18, 2022 at 07:10:59AM +0000, Biju Das wrote:
> > Hi Stephen and Mark,
> >
> > My bad, I have added Fixes tag at last minute and missed running Check
> > patch with that change.
> >
> > Is it possible to manually fix this?
>
> No, that'd involve rebasing. It's fine, just remember this in future.

OK, Will take care this in future.

By the way, I have ran check patch on this patch on Linux-next and unfortunately
It doesn't complain about leading 'commit' in fixes tag.

Thanks,
Biju

2022-03-18 20:56:14

by Mark Brown

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the spi tree

On Fri, Mar 18, 2022 at 07:10:59AM +0000, Biju Das wrote:
> Hi Stephen and Mark,
>
> My bad, I have added Fixes tag at last minute and missed running
> Check patch with that change.
>
> Is it possible to manually fix this?

No, that'd involve rebasing. It's fine, just remember this in future.


Attachments:
(No filename) (306.00 B)
signature.asc (499.00 B)
Download all attachments