2023-06-24 04:01:14

by Lee, Kah Jing

[permalink] [raw]
Subject: RE: [v2 1/2] arm64: dts: agilex/stratix10: Updated QSPI Flash layout for UBIFS

> -----Original Message-----
> From: Markus Elfring <[email protected]>
> Sent: Friday, 23 June, 2023 7:04 PM
> To: Lee, Kah Jing <[email protected]>; Yuslaimi, Alif Zakuan
> <[email protected]>; [email protected]; kernel-
> [email protected]; Catalin Marinas <[email protected]>;
> Conor Dooley <[email protected]>; Dinh Nguyen <[email protected]>;
> Rob Herring <[email protected]>; Krzysztof Kozlowski
> <[email protected]>; Will Deacon <[email protected]>
> Cc: LKML <[email protected]>; [email protected]
> Subject: Re: [v2 1/2] arm64: dts: agilex/stratix10: Updated QSPI Flash layout
> for UBIFS
>
> > Updated in v3 - Commit message:
> > Update the QSPI flash layout to support UBIFS in mtd root partition.
> > Flash layout is updated in order to store non-UBIFS related boot and
> > fpga data in qspi_boot(mtd0) while keep the rootfs with UBIFS in the root
> partition(mtd1).
>
> I got the impression that this change description is also improvable a bit.
> How do you think about a wording variant like the following?
>
>
> Non-UBIFS related boot and fpga data should be stored in qspi_boot (mtd0)
> while keeping the rootfs with UBIFS in the root partition “mtd1”.
> Thus update the QSPI flash layout to support UBIFS in the mtd root partition.
>
>
> Will similar adjustments become helpful for subsequent update steps?
Sounds good to me. Will update the commit message for v3.
Thanks.
>
> Regards,
> Markus

Regards,
Lee, Kah Jing