2002-11-12 22:05:05

by Pete Zaitcev

Subject: path_release missing or not?

Al, please tell me if the patch below is bogus. I checked paths
and it looks right, but I may be missing something.

-- Pete

--- linux-2.4.19/fs/namei.c 2002-08-02 17:39:45.000000000 -0700
+++ linux-2.4.19-p3/fs/namei.c 2002-11-12 14:01:55.000000000 -0800
@@ -1984,8 +1984,10 @@
* bloody create() on broken symlinks. Furrfu...
*/
name = __getname();
- if (!name)
+ if (!name) {
+ path_release(nd);
return -ENOMEM;
+ }
strcpy(name, nd->last.name);
nd->last.name = name;
return 0;

2002-11-12 22:22:12

by Alexander Viro

Subject: Re: path_release missing or not?

On Tue, 12 Nov 2002, Pete Zaitcev wrote:

> Al, please tell me if the patch below is bogus. I checked paths
> and it looks right, but I may be missing something.

Looks fine.