2000-12-16 15:12:42

by Jani Monoses

[permalink] [raw]
Subject: kernel-doc minor fix


Hi

inline docs are not generated for functions which return a 'const'
because this modifier is not checked for (only inline extern and static)
when verifying the function prototype.
This patch fixes it and hopefully doesn't break anything else(I am
Perl----)

Jani.

--- /usr/src/linux/scripts/kernel-doc Tue Dec 12 11:25:59 2000
+++ kernel-doc Sat Dec 16 15:53:17 2000
@@ -664,10 +664,11 @@

##
# takes a function prototype and spits out all the details
-# stored in the global arrays/hsahes.
+# stored in the global arrays/hashes.
sub dump_function {
my $prototype = shift @_;

+ $prototype =~ s/^const+ //;
$prototype =~ s/^static+ //;
$prototype =~ s/^extern+ //;
$prototype =~ s/^inline+ //;


2000-12-18 08:15:49

by Simon Huggins

[permalink] [raw]
Subject: Re: kernel-doc minor fix

On Sat, Dec 16, 2000 at 04:41:44PM +0200, Jani Monoses wrote:
> --- /usr/src/linux/scripts/kernel-doc Tue Dec 12 11:25:59 2000
> +++ kernel-doc Sat Dec 16 15:53:17 2000
> @@ -664,10 +664,11 @@

> ##
> # takes a function prototype and spits out all the details
> -# stored in the global arrays/hsahes.
> +# stored in the global arrays/hashes.
> sub dump_function {
> my $prototype = shift @_;

> + $prototype =~ s/^const+ //;
> $prototype =~ s/^static+ //;
> $prototype =~ s/^extern+ //;
> $prototype =~ s/^inline+ //;

Since when did C accept constttttttttttttttttttt and staticcccccccc?
etc.

Should that be " +" not "+ " or is someone just trying to confuse me?
Or did someone try to mean s/foo//g by adding a +?


Yours confusedly,

Simon.

--
[ "Therapy is expensive. Popping bubble wrap is cheap. You choose." ]

2000-12-18 09:35:56

by Jani Monoses

[permalink] [raw]
Subject: Re: kernel-doc minor fix



On Sun, 17 Dec 2000, Simon Huggins wrote:

> On Sat, Dec 16, 2000 at 04:41:44PM +0200, Jani Monoses wrote:
> > + $prototype =~ s/^const+ //;
> Yours confusedly,
>
> Simon.

Hi

I can't answer to your question but this patch is not good anyway as Tim
pointed out to me.


Jani.