2002-09-12 07:16:14

by Rusty Russell

[permalink] [raw]
Subject: [PATCH] Generated files destruction

Linus, please apply.

I would like to start migrating all build-generated files to
names matching "generated*" or ".generated*", esp. those which look
like source files. This is mainly for readability and for simplicity
when diffing built kernel trees. I'll be encouraging various
maintainers who generate (.c, .h and .s) files which are not meant to
be shipped with the kernel source to migrate, in my copious free
time...

Cheers!
Rusty.

diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.5.34/Makefile working-2.5.34-generated-remove/Makefile
--- linux-2.5.34/Makefile 2002-09-10 09:11:14.000000000 +1000
+++ working-2.5.34-generated-remove/Makefile 2002-09-12 17:09:06.000000000 +1000
@@ -660,6 +660,7 @@ clean: archclean
@echo 'Cleaning up'
@find . -name SCCS -prune -o -name BitKeeper -prune -o \
\( -name \*.[oas] -o -name core -o -name .\*.cmd -o \
+ -name generated\* -o -name .generated\* -o \
-name .\*.tmp -o -name .\*.d \) -type f -print \
| grep -v lxdialog/ | xargs rm -f
@rm -f $(CLEAN_FILES)

--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.


2002-09-12 20:49:14

by Kai Germaschewski

[permalink] [raw]
Subject: Re: [PATCH] Generated files destruction

On Thu, 12 Sep 2002, Rusty Russell wrote:

> I would like to start migrating all build-generated files to
> names matching "generated*" or ".generated*", esp. those which look
> like source files. This is mainly for readability and for simplicity
> when diffing built kernel trees. I'll be encouraging various
> maintainers who generate (.c, .h and .s) files which are not meant to
> be shipped with the kernel source to migrate, in my copious free
> time...

I think the proper solution here is actually separate obj/src dirs,
instead of special names. It's actually quite easy to get that implemented
in the current kbuild, I just didn't find the time for proper testing yet.
I'll have a patch ready for testing soon, though.

-Kai


2002-09-13 01:51:11

by Rusty Russell

[permalink] [raw]
Subject: Re: [PATCH] Generated files destruction

In message <[email protected]> y
ou write:
> On Thu, 12 Sep 2002, Rusty Russell wrote:
>
> > I would like to start migrating all build-generated files to
> > names matching "generated*" or ".generated*", esp. those which look
> > like source files. This is mainly for readability and for simplicity
> > when diffing built kernel trees. I'll be encouraging various
> > maintainers who generate (.c, .h and .s) files which are not meant to
> > be shipped with the kernel source to migrate, in my copious free
> > time...
>
> I think the proper solution here is actually separate obj/src dirs,
> instead of special names. It's actually quite easy to get that implemented
> in the current kbuild, I just didn't find the time for proper testing yet.
> I'll have a patch ready for testing soon, though.

Sure, if it basically comes for free. Otherwise, I don't see any
attraction in separating them: cp -al linux-2.5.34 working-2.5.34-foo
takes a couple of seconds.

Cheers!
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

2002-09-30 16:19:08

by Linus Torvalds

[permalink] [raw]
Subject: Re: [PATCH] Generated files destruction


On Thu, 12 Sep 2002, Kai Germaschewski wrote:
>
> I think the proper solution here is actually separate obj/src dirs,
> instead of special names. It's actually quite easy to get that implemented
> in the current kbuild, I just didn't find the time for proper testing yet.
> I'll have a patch ready for testing soon, though.

Please keep in mind that some people (at least me) don't like separate
build trees - I do all the "real work" in the source directory, and if I
need to go somewhere else to build, that's just a pain (and it's another
pain if, once I'm building, I have to use a different path than the one
that I'm used to in the source directory to fix something).

So I want to keep the mixed tree around (which is not to say that people
who like the separate-object-tree thing shouldn't be _able_ to use it).

Linus