2002-09-15 22:40:39

by Albert Cranford

[permalink] [raw]
Subject: [patch 8/9]Four new i2c drivers and __init/__exit cleanup to i2c

Hello Linus,
New I2C drivers that have been adjusted after Russell King comments of August.
o i2c-algo-8xx.c
o i2c-pport.c
o i2c-adap-ibm_ocp.c
o i2c-pcf-epp.c
o Add new drivers to Config.in and Makefile.
o Add new drivers to i2c-core for initialization.
o Remove EXPORT_NO_SYMBOLS statement from i2c-dev, i2c-elektor and i2c-frodo.
o Cleanup init_module and cleanup_module adding __init and __exit to most drivers.
o Adjust i2c-elektor with cli/sti replacement.
--
[email protected]


Attachments:
47-i2c-7-patch (7.85 kB)

2002-09-15 23:11:52

by Jeff Garzik

[permalink] [raw]
Subject: Re: [patch 8/9]Four new i2c drivers and __init/__exit cleanup to i2c

Albert Cranford wrote:
> --- linux/drivers/i2c/i2c-adap-ibm_ocp.c.orig 2002-09-13 01:16:58.000000000 -0400
> +++ linux-2.5.34/drivers/i2c/i2c-adap-ibm_ocp.c 2002-09-15 01:13:57.000000000 -0400
> @@ -90,6 +90,14 @@
> static wait_queue_head_t iic_wait[IIC_NUMS];
> static int iic_pending;
>
> +#ifdef MODULE
> +static
> +#else
> +extern
> +#endif
> + int __init iic_ibmocp_init(void);
> +static void __exit iic_ibmocp_exit(void);
> +

ug, don't add this crap to the codebase...



> --- linux/drivers/i2c/i2c-algo-8xx.c.orig 2002-09-13 01:17:07.000000000 -0400
> +++ linux-2.5.34/drivers/i2c/i2c-algo-8xx.c 2002-09-13 01:47:42.000000000 -0400
> @@ -51,6 +51,13 @@
> int cpm_scan = 1;
> int cpm_debug = 0;
>
> +#ifdef MODULE
> +static
> +#else
> +extern
> +#endif
> + int __init i2c_algo_8xx_init (void);
> +

likewise [repeated many times]